fix: fetch-module→zipx DRY + doctor parseFail（审查 e95d81e / #54 后债） - #55
Merged
Tanya7z merged 1 commit intoJul 23, 2026
Merged
Conversation
审查 main@e95d81e ootb 红（#51+#52 合并残留）后 #54 已修 TS2300； 本补丁收敛遗留 SOLID 债： - MAJOR(DRY): tools/fetch-module 解压委托 @sfmc-bds/bds-tools/zipx - MAJOR(LSP): readWorldPackListResult 恢复 doctor parseFail 信号 - MINOR(DRY): cmdUpdate 直接 stripTaskbarOsc，去掉无用 stripOsc 别名 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 23, 2026 16:15
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
main@e95d81eootb 因 #51+#52 合并残留extractZipFileToDir重复 import（TS2300）失败；#54 已合入修复并额外完成 wizard→zipx。本 PR 收敛审查后仍开放的 SOLID 债。改动
MAJOR — DRY
tools/fetch-module.mjs本地 JSZip 解压删除，改走@sfmc-bds/bds-tools/zipx（与 world-packs / updater / wizard 同一权威）tools声明对bds-tools的依赖；根package.json去掉仅供 fetch-module 的jszipMAJOR — LSP / Demeter
readWorldPackListResult/listWorldEnableListResult：文件缺失 vs JSON 损坏可区分packs doctor恢复packs.doctor.parseFail（fix(world-packs): zip-slip + 冲突静默覆盖 + DRY enable-list（审查 169488a） #51 Demeter 重构后该信号丢失）readWorldPackList()仍返回entries数组，既有调用契约不变MINOR — DRY
sfmc/commands去掉无用的stripOsc透传，直接调用stripTaskbarOsc验证
审查原则
DRY · OCP · DIP · LSP · Law of Demeter
仍开放（未在本 PR）