fix(bds-tools): 去除 check-update 重复 zipx import(修 ootb TS2300) - #53
Closed
cursor[bot] wants to merge 1 commit into
Closed
fix(bds-tools): 去除 check-update 重复 zipx import(修 ootb TS2300)#53cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
4 tasks
Tanya7z
marked this pull request as ready for review
July 23, 2026 16:08
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main合入 #51 后再合 #52 时,bds-tools/src/check-update.ts两边各自保留了import { extractZipFileToDir } from "./zipx.js",触发TS2300: Duplicate identifier 'extractZipFileToDir',ootbBuild all workspaces失败(run30023000049/30022984639)。审查(DRY)
遗留(不在本 PR)
sfmc/wizard.extractZip与bds-tools/zipx仍双份,可后续收敛。Test plan
npm run build --workspaces --if-presentcd bds-tools && npm test→ 18/18SFMC_ROOT=$PWD node tools/check-ootb.mjs→ 12/12