Skip to content

fix(bds-tools): 去除 check-update 重复 zipx import(修 ootb TS2300) - #53

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/bc-155825da-b59a-453d-a7c0-15a206d4265a-46e6
Closed

fix(bds-tools): 去除 check-update 重复 zipx import(修 ootb TS2300)#53
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/bc-155825da-b59a-453d-a7c0-15a206d4265a-46e6

Conversation

@cursor

@cursor cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

main 合入 #51 后再合 #52 时,bds-tools/src/check-update.ts 两边各自保留了 import { extractZipFileToDir } from "./zipx.js",触发 TS2300: Duplicate identifier 'extractZipFileToDir',ootb Build all workspaces 失败(run 30023000049 / 30022984639)。

审查(DRY)

遗留(不在本 PR)

  • MINOR(DRY):sfmc/wizard.extractZipbds-tools/zipx 仍双份,可后续收敛。

Test plan

  • npm run build --workspaces --if-present
  • cd bds-tools && npm test → 18/18
  • SFMC_ROOT=$PWD node tools/check-ootb.mjs → 12/12
Open in Web View Automation 

#51/#52 合并时两边各自保留了 extractZipFileToDir 导入,
触发 TS2300 Duplicate identifier,导致 ootb build 失败。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z
Tanya7z marked this pull request as ready for review July 23, 2026 16:08
@cursor

cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z Tanya7z closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants