fix(wf@ec7986b): TS6133 + banned_items/canDisable LSP after #37 - #39
Merged
Tanya7z merged 2 commits intoJul 22, 2026
Merged
Conversation
3 tasks
3 tasks
ootb Build 在合入 #37 后仍红:sfmc MODULE_HELP_LABEL 未使用(TS6133)。 HELP 改用 paintModuleCmdAlias 一次染色常量;删未使用 MODULE_CMD_ALIAS_LABEL。 SOLID: - LSP:configs/all.banned_items 改为 string[](与 /banned_items、ConfigManager 同源) - DRY:getAllConfigs 委托单资源 helpers - LSP:moduleCanDisable 供 list/disable 同源(省略 canDisable 视为可禁用) - DRY/OCP:builtin 热启停按 moduleId 卸装,去掉 serviceNames 副本 - OCP/DRY:db/tx 交互会话路由表扩展,勿复制四份 try/catch - LSP:ConfigManager 兼容历史 {item_id};service.get 保留服务端 code Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
…联合类型
db-routes 会话表入参避免 step:undefined 触碰 exactOptionalPropertyTypes;
ConfigManager.banned_items 标注 string|{item_id} 以匹配兼容解析。
Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
3 tasks
Tanya7z
force-pushed
the
cursor/bc-52d8f5d4-ffbe-4e2b-9fab-b3fe49cc163e-c8f1
branch
from
July 22, 2026 18:05
1a61394 to
211f247
Compare
Tanya7z
marked this pull request as ready for review
July 22, 2026 18:05
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
审查报告 — push merge #39 → main@e16b101
CI
- ootb run 29945175741 → success（Build / check-ootb / smoke 全绿）
- 此前 #37ec7986b 的 TS6133 Build 失败已由本 PR 修复
DRY / OCP / DIP / LSP / Demeter
| 级别 | 原则 | 项 | 结论 |
|---|---|---|---|
| — | — | 无新 BLOCKER | ✅ |
| FIXED | DRY | MODULE_HELP_LABEL 死代码 → TS6133 |
✅ 本 PR |
| FIXED | LSP | banned_items / moduleCanDisable |
✅ 本 PR |
| FIXED | DRY/OCP | builtin 按 moduleId 卸装（去 serviceNames） |
✅ 本 PR |
| FIXED | OCP/DRY | db/tx sessionOps 表 |
✅ 本 PR |
| MINOR | Demeter | cleanupModule 仍无参清全部 context |
另开补丁 PR（#41 SDK 差额） |
| MINOR | DRY/LSP | 平台 legacy {success} vs v2 {ok} |
有意延后（SDK dual-accept） |
建议
- 关闭与本 PR 重叠的草稿 #41（db-server 已合入；仅 SDK LoD 仍缺）
- 合入承接 LoD 的后续补丁 PR
Sent by Cursor Automation: SFMC-Review
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
合入 #37 后
ootb在 Build 阶段仍失败：sfmc/src/repl.ts遗留未使用的MODULE_HELP_LABEL→TS6133（#32/#33 合并残留；#34/#35/#36 未合入前被 #37 抢先落地了热启停/交互 tx）。本 PR 修 CI，并补上审查发现的可验证 SOLID 债：
paintModuleCmdAlias一次染色为MODULE_HELP_LABEL；删除未使用的MODULE_CMD_ALIAS_LABELconfigs/all.banned_items改为string[]（与/banned_items、ConfigManager 契约对齐）getAllConfigs委托单资源 helpers，消除双写moduleCanDisable供 list/disable 同源（省略canDisable视为可禁用）moduleId卸装，去掉serviceNames硬编码副本db/tx交互会话改路由表扩展，勿复制四份 try/catch{item_id}；service.get保留服务端codeTest plan
npm run build --workspaces --if-presentcd db-server && npm test（12/12）SFMC_ROOT=$PWD node tools/check-ootb.mjs→ 11/11 PASS