Skip to content

fix(wf@ec7986b): TS6133 MODULE_HELP_LABEL + banned_items/canDisable LSP - #38

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/bc-27fd71f9-f47b-46b0-882a-8a4f77d2e25b-a9ed
Closed

fix(wf@ec7986b): TS6133 MODULE_HELP_LABEL + banned_items/canDisable LSP#38
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/bc-27fd71f9-f47b-46b0-882a-8a4f77d2e25b-a9ed

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

合入 #37ootbBuild 阶段仍失败:sfmc/src/repl.ts 遗留未使用的 MODULE_HELP_LABELTS6133noUnusedLocals)。

根因:#32 引入 MODULE_HELP_LABEL#33 改用 paintModuleCmdAlias,两套并存;#36 拟修但未合入且与 #37 冲突。

本 PR 不重复 #37 已落地的热同步 / 交互 tx,只补 CI 阻断与剩余可验证 SOLID 债:

级别 原则 修复
BLOCKER DRY HELP 用 paintModuleCmdAlias 一次染色为 MODULE_HELP_LABEL;删除未使用的 MODULE_CMD_ALIAS_LABEL
MAJOR LSP + DRY configs/all.banned_items 改为 string[]getAllConfigs 复用单资源 helpers
MAJOR LSP + DRY moduleCanDisable 同源 — list 的 can_disable 与 disable 门禁一致
MINOR LSP ConfigManager 兼容历史 {item_id}service.get 保留服务端 code
CI check-ootb 锁定 banned_itemsstring[]

与开放 PR 的关系

Test plan

  • npm run build --workspaces --if-present
  • cd db-server && npm test(12/12)
  • SFMC_ROOT=$PWD node tools/check-ootb.mjs11/11 PASS
Open in Web View Automation 

合入 #37 后 ootb 仍因 #33/#32 合并残留 MODULE_HELP_LABEL 未使用而红。
HELP 改用 paintModuleCmdAlias 一次染色;删死代码 MODULE_CMD_ALIAS_LABEL。
configs/all.banned_items 改为 string[] 并复用 helpers;moduleCanDisable
与 list/disable 同源;ConfigManager/service.get 做 LSP 防御。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z

Tanya7z commented Jul 22, 2026

Copy link
Copy Markdown
Member

关闭:与 #39 同轨(TS6133 MODULE_HELP_LABEL + banned_items/canDisable),#39 为超集。热同步已由 #37+#36 覆盖。

@Tanya7z Tanya7z closed this Jul 22, 2026
@Tanya7z
Tanya7z deleted the cursor/bc-27fd71f9-f47b-46b0-882a-8a4f77d2e25b-a9ed branch July 23, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants