fix(wf@ec7986b): TS6133 MODULE_HELP_LABEL + banned_items/canDisable LSP - #38
Closed
cursor[bot] wants to merge 1 commit into
Closed
fix(wf@ec7986b): TS6133 MODULE_HELP_LABEL + banned_items/canDisable LSP#38cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
合入 #37 后
ootb在 Build 阶段仍失败:sfmc/src/repl.ts遗留未使用的MODULE_HELP_LABEL→TS6133(noUnusedLocals)。根因:#32 引入
MODULE_HELP_LABEL,#33 改用paintModuleCmdAlias,两套并存;#36 拟修但未合入且与 #37 冲突。本 PR 不重复 #37 已落地的热同步 / 交互 tx,只补 CI 阻断与剩余可验证 SOLID 债:
paintModuleCmdAlias一次染色为MODULE_HELP_LABEL;删除未使用的MODULE_CMD_ALIAS_LABELconfigs/all.banned_items改为string[],getAllConfigs复用单资源 helpersmoduleCanDisable同源 — list 的can_disable与 disable 门禁一致{item_id};service.get保留服务端codecheck-ootb锁定banned_items为string[]与开放 PR 的关系
module-runtime-sync.ts(会冲突/重复)。建议合本 PR 后关闭 fix(ci@3d15949): #33 合并残留 TS6133 + configs/all banned_items / canDisable LSP #34/fix(wf@3d15949): #33 合并 TS6133 + banned_items/canDisable LSP #35/fix(wf@3d15949): TS6133 MODULE_HELP_LABEL + enable 热同步 token/enabledSet #36。Test plan
npm run build --workspaces --if-presentcd db-server && npm test(12/12)SFMC_ROOT=$PWD node tools/check-ootb.mjs→ 11/11 PASS