Skip to content

fix(solid@85815c2): builtin moduleId 卸装 + tx session 表 + cleanup LoD - #41

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/bc-289d6102-a911-4404-bc56-50540017927c-c089
Closed

fix(solid@85815c2): builtin moduleId 卸装 + tx session 表 + cleanup LoD#41
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/bc-289d6102-a911-4404-bc56-50540017927c-c089

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

合入 #36ootb@85815c2 已绿(run 29944458105)。本 PR 补上审查发现、且尚未落地的可验证 SOLID 债(原 #39 超集中与 main 冲突的部分)。

级别 原则 修复
MAJOR DRY / OCP builtin-handlers 去掉 serviceNames 硬编码副本;热启停以 registry.list().moduleId 为权威
MINOR OCP / DRY db/tx begin|step|commit|rollback 收成 sessionOps 表,新增会话动词不必再复制四份 try/catch
MINOR Demeter cleanupModule 只清本模块 config 桶,且仅在身份匹配时清空 db/service 全局上下文

审查结论(相对 main@85815c2 / #36

Test plan

  • npm run build --workspaces --if-present
  • cd db-server && npm test13/13
  • SFMC_ROOT=$PWD node tools/check-ootb.mjs11/11 PASS

Out of scope

  • 平台 legacy {success} 方言全量迁移
Open in Web View Automation 

合入 #36 后 ootb 已绿;补上 #39 未落地的可验证 SOLID 债:
- MAJOR DRY/OCP: builtin-handlers 去掉 serviceNames 硬编码副本,热启停以 registry.moduleId 为权威
- MINOR OCP/DRY: db/tx begin|step|commit|rollback 收成 sessionOps 表
- MINOR Demeter: cleanupModule 只清本模块 config 桶 / 匹配的 db·service 身份

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@cursor
cursor Bot marked this pull request as ready for review July 22, 2026 18:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

状态更新 — 相对 main@e16b101(已合 #39

本 PR 原目标 现状
builtin moduleId 卸装 + sessionOps 已由 #39 合入 main(blob 相同)
SDK cleanupModule LoD(clear*(id) 仍未合入 — 已拆到独立补丁 PR 承接

建议

关闭本 PR,避免与 main 重复的 db-server diff 再起冲突;SDK Demeter 差额请审独立 PR。

Open in Web View Automation 

Sent by Cursor Automation: SFMC-Review

@Tanya7z

Tanya7z commented Jul 23, 2026

Copy link
Copy Markdown
Member

关闭:db-server 部分已由 #39 合入;SDK cleanupModule 按 moduleId 限定清上下文由超集/后续 #42 覆盖。勿再合 #41(相对 main 已分叉且会重触 #39 路径)。

@Tanya7z Tanya7z closed this Jul 23, 2026
@Tanya7z
Tanya7z deleted the cursor/bc-289d6102-a911-4404-bc56-50540017927c-c089 branch July 23, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants