fix(solid@85815c2): builtin moduleId 卸装 + tx session 表 + cleanup LoD - #41
Closed
cursor[bot] wants to merge 1 commit into
Closed
fix(solid@85815c2): builtin moduleId 卸装 + tx session 表 + cleanup LoD#41cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
合入 #36 后 ootb 已绿;补上 #39 未落地的可验证 SOLID 债: - MAJOR DRY/OCP: builtin-handlers 去掉 serviceNames 硬编码副本,热启停以 registry.moduleId 为权威 - MINOR OCP/DRY: db/tx begin|step|commit|rollback 收成 sessionOps 表 - MINOR Demeter: cleanupModule 只清本模块 config 桶 / 匹配的 db·service 身份 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
3 tasks
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
合入 #36 后
ootb@85815c2 已绿(run 29944458105)。本 PR 补上审查发现、且尚未落地的可验证 SOLID 债(原 #39 超集中与 main 冲突的部分)。builtin-handlers去掉serviceNames硬编码副本;热启停以registry.list().moduleId为权威db/txbegin|step|commit|rollback 收成sessionOps表,新增会话动词不必再复制四份 try/catchcleanupModule只清本模块 config 桶,且仅在身份匹配时清空 db/service 全局上下文审查结论(相对 main@85815c2 / #36)
Test plan
npm run build --workspaces --if-presentcd db-server && npm test→ 13/13SFMC_ROOT=$PWD node tools/check-ootb.mjs→ 11/11 PASSOut of scope
{success}方言全量迁移