Skip to content

fix(solid@e16b101): cleanupModule 按 moduleId 限定清上下文 (Demeter) - #42

Merged
Tanya7z merged 1 commit into
mainfrom
cursor/bc-240e0403-52f5-46a8-9f6f-ef4ac6b05fa2-ff67
Jul 23, 2026
Merged

fix(solid@e16b101): cleanupModule 按 moduleId 限定清上下文 (Demeter)#42
Tanya7z merged 1 commit into
mainfrom
cursor/bc-240e0403-52f5-46a8-9f6f-ef4ac6b05fa2-ff67

Conversation

@cursor

@cursor cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

合入 #39ootb@e16b101 已绿(run 29945175741)。本 PR 补上审查发现、且尚未落地的 SDK Law of Demeter 差额(原 #41 中 db-server 部分已由 #39 吸收)。

级别 原则 修复
MINOR Demeter / OCP cleanupModuleclear*(id):禁用模块 A 时不误清 B 的 config 桶 / db·service 身份

审查结论(push merge #39 → main@e16b101)

Test plan

  • npm run build --workspaces --if-present
  • npm run typecheck -w @sfmc-bds/sdk
  • cd db-server && npm test13/13
  • SFMC_ROOT=$PWD node tools/check-ootb.mjs11/11 PASS

Out of scope

  • 平台 legacy {success} 方言全量迁移(SDK 已 dual-accept)
Open in Web View Automation 

合入 #39 后 ootb 已绿;补上 #41 仍未落地的 SDK LoD 差额:
- clearConfigModuleContext(id) 只删该模块 config 桶
- clearDb/ServiceModuleContext(id) 仅在身份匹配时清空
- cleanupModule 传入 id,禁用 A 不误清 B

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z
Tanya7z marked this pull request as ready for review July 23, 2026 02:43
@cursor

cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z
Tanya7z merged commit a88542c into main Jul 23, 2026
1 check passed
@Tanya7z
Tanya7z deleted the cursor/bc-240e0403-52f5-46a8-9f6f-ef4ac6b05fa2-ff67 branch July 23, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants