Repository navigation
tests: damage the teams store, not a teams.json, before continuing a chat - #2182
Open
santoshkumarradha wants to merge 2 commits into
Open
santoshkumarradha wants to merge 2 commits into
santoshkumarradha wants to merge 2 commits into
Conversation
…chat #2066 moved teams into an SQLite store. TestContinuingAChatKeepsItsLease- DespiteDamagedTeamsAndLaterHeals still damaged teams by overwriting the bytes at teams.Path and later wrote them back, which no longer breaks the store, so the take never met a failed rebind and never said so. It now uses teamstest.Break and its restore, as the other teams tests did in #2099.
This was referenced Nov 2, 2026
santoshkumarradha
marked this pull request as ready for review
November 2, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Only one test.
TestContinuingAChatKeepsItsLeaseDespiteDamagedTeamsAndLaterHealsdamaged a computer's teams by overwriting the bytes atteams.Pathand later wrote them back. Since #2066 teams live in an SQLite store, so that no longer damages anything: the take never met a failed rebind and the test failed atfailed rebind had no notice. It now usesteamstest.Breakand its restore, as the other teams tests have done since #2099. The assertions are unchanged.Validation
BUILD_EXIT=0 VET_EXIT=0 FMT_EXIT=0 CHANGELOG_EXIT=0 LAWS_EXIT=2 PKG_EXIT=1 (./internal/syncsetup). LAWS_EXIT=2 comes from the known base reds only: TestSourceComments, which flags two factory pipeline_copy files; the taxonomy law; and the two NoRoad complexity laws. TestContinuingAChatKeepsItsLeaseDespiteDamagedTeamsAndLaterHeals passes. PKG_EXIT=1 comes from four syncsetup tests that sibling PRs fix, all on app/v3 or queued after this branch's base: watch displacement (syncsetup: an ownership check that finds another holder retires the send receipt first #2180), the reopened-writer return (tests: F1 reopen resumes the same hold (stale-consent and hosted take-back tests) #2183), the stale-publish notice (tests: the stale-publish test waits for the announced move, not the first viewer line #2185) and the kept unsent turn (tests: keeping an unsent turn on an ownership check needs the store to answer #2184).Limits
Test-only change. No product behaviour changes.
🤖 Generated with Claude Code