Repository navigation
syncsetup: a window that takes its released chat back is a writer again - #2186
Merged
Merged
Conversation
When another computer takes a chat and then releases it (a failed install), this window's ownership check first meets the other holder and marks the hold lost. The next send reads the released lease, ConfirmWork reacquires it and clears the viewer line, but it left lost set, and Gate still refused every tool and send with 'another device continued this chat'. The lost flag came with the dev merge (#2099) next to an older reacquire path that only knew the viewer line. Reacquiring now clears both, as resumeViewer already does.
santoshkumarradha
marked this pull request as ready for review
November 2, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for a person
A computer starts to continue a chat from this one, and the move fails (for example, it cannot install the chat) and releases it. This window should then be able to keep working: the next message takes the released chat back. Before, the window took the hold back but still refused every message and tool with "another device continued this chat; this window now only shows it".
Root cause
The ownership check that met the other computer marked this window's hold as lost. On the next send,
Drive.ConfirmWorkread the released lease and reacquired it, and it cleared the viewer line, but it left the lost flag set, andGaterefuses while lost is set. The lost flag came with the dev merge (#2099) next to this older reacquire path, which only knew the viewer line. Reacquiring now clears both, asresumeVieweralready does.Validation
TestAppTakeInstallFailureS5(cmd/codeaf) is the regression test. It needs the real engine. With the pinned furrow engine present it failed on app/v3 (S5 source send: conflict: another device continued this chat) and passes with this change. It passed before the merge in Merge dev (#2020–#2092) into app/v3 #2099.BUILD_EXIT=0 VET_EXIT=0 FMT_EXIT=0 CHANGELOG_EXIT=0 LAWS_EXIT=2 PKG_EXIT=1 (./internal/syncsetup) CMDRUN_EXIT=0 (^(TestAppTakeInstallFailureS5)$). LAWS_EXIT=2 comes from the known base reds only: TestSourceComments, which flags two factory pipeline_copy files; the taxonomy law; and the two NoRoad complexity laws. PKG_EXIT=1 comes only from seal reds that sibling PRs fix: syncsetup: an ownership check that finds another holder retires the send receipt first #2180 (already on app/v3; this branch predates it), tests: damage the teams store, not a teams.json, before continuing a chat #2182, tests: F1 reopen resumes the same hold (stale-consent and hosted take-back tests) #2183 and tests: keeping an unsent turn on an ownership check needs the store to answer #2184.Limits
None known.
🤖 Generated with Claude Code