Repository navigation
tests: the stale-publish test waits for the announced move, not the first viewer line - #2185
Merged
Merged
Conversation
…irst viewer line Since #1971 a displaced window refuses work at once, first with an unnamed line while the holder's name is read, and announces the move only after its pending saves settle. TestStalePublishRefusalMakesViewerAndNotifiesOnce came from dev, where the line was set together with the notices, and waited only for any viewer line. With the real engine it then read the unnamed line or an empty notice list (1 in 3 to 1 in 10 runs alone). It now waits for the announcement, the settled state, and its assertions are unchanged.
This was referenced Nov 2, 2026
santoshkumarradha
marked this pull request as ready for review
November 2, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Only one test. Since #1971 a chat that another computer continued refuses work at once: it first shows an unnamed line while it reads the other computer's name, and it announces the move only after its pending saves settle.
TestStalePublishRefusalMakesViewerAndNotifiesOncecame from dev, where the line and the notices were set together, and it waited only for any viewer line. With the real engine present it then sometimes read the unnamed line, or an empty notice list (1 in 3 to 1 in 10 runs alone on app/v3).It now waits for the announcement, which is the settled state. The checks are unchanged: the window names the new holder, and the notices are the kept turn and the move, once each.
Validation
BUILD_EXIT=0 VET_EXIT=0 FMT_EXIT=0 CHANGELOG_EXIT=0 LAWS_EXIT=2 PKG_EXIT=1 (./internal/syncsetup). LAWS_EXIT=2 comes from the known base reds only: TestSourceComments, which flags two factory pipeline_copy files; the taxonomy law; and the two NoRoad complexity laws. TestStalePublishRefusalMakesViewerAndNotifiesOnce passes. PKG_EXIT=1 comes from four syncsetup tests that sibling PRs fix: watch displacement (syncsetup: an ownership check that finds another holder retires the send receipt first #2180, merged after this branch's base), the reopened-writer return (tests: F1 reopen resumes the same hold (stale-consent and hosted take-back tests) #2183), the kept unsent turn (tests: keeping an unsent turn on an ownership check needs the store to answer #2184) and the damaged teams store (tests: damage the teams store, not a teams.json, before continuing a chat #2182).Limits
Test-only change. No product behaviour changes.
🤖 Generated with Claude Code