Skip to content

tests: damage the teams store, not a teams.json, before continuing a chat #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santoshkumarradha wants to merge 2 commits into
base: app/v3
Choose a base branch
from
Open

tests: damage the teams store, not a teams.json, before continuing a chat #2182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1ed1d2
tests: damage the teams store, not a teams.json, before continuing a …
santoshkumarradha Nov 2, 2026
28bad30
docs: change entry for this pull request
santoshkumarradha Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changes/unreleased/2182-teams-store-test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
kind: internal
title: The damaged-teams continuation test damages the SQLite teams store
pr: 2182
surface: [chat]
---
13 changes: 3 additions & 10 deletions internal/syncsetup/teams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,13 +407,8 @@ func TestContinuingAChatKeepsItsLeaseDespiteDamagedTeamsAndLaterHeals(t *testing
if err := h.b.SyncState(ctx); err != nil {
t.Fatal(err)
}
good, err := os.ReadFile(teams.Path(h.b.Home))
if err != nil {
t.Fatal(err)
}
if err := os.WriteFile(teams.Path(h.b.Home), []byte("damaged"), 0600); err != nil {
t.Fatal(err)
}
// app/v3 keeps teams in an SQLite store (#2066): damage the store itself.
restore := teamstest.Break(t, h.b.Home, []byte("damaged"))
h.lapse()
took, err := h.continuerB().Take(ctx, h.cell.ID)
if err != nil {
Expand All @@ -430,9 +425,7 @@ func TestContinuingAChatKeepsItsLeaseDespiteDamagedTeamsAndLaterHeals(t *testing
if err != nil || string(received) != string(cursor) {
t.Fatal("cursor fixture did not travel", string(received), err)
}
if err := os.WriteFile(teams.Path(h.b.Home), good, 0600); err != nil {
t.Fatal(err)
}
restore()
if err := h.b.SyncState(ctx); err != nil {
t.Fatal(err)
}
Expand Down