[Raiden Weight Sync 2/7] Support inhomogeneous layer cycle interval in raiden_unscan - #5167
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for inhomogeneous layer cycles in unscan_layers by adding a cycle_interval parameter, which allows scanning blocks of heterogeneous layers and folding the slot index into the physical layer number. It also adds a comprehensive unit test suite for the unscan_layers functionality. The review feedback suggests optimizing the regular expression matching to avoid redundant calls, adding validation to ensure the parsed slot index is strictly less than the cycle interval to prevent silent weight overwriting, and expanding the unit tests to cover the new cycle_interval logic and its error paths.
igorts-git
left a comment
There was a problem hiding this comment.
please address review bot comments. I think they are meaningful.
45b94fd to
e16fd8a
Compare
683a591 to
a5e2f1b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a5e2f1b to
838de91
Compare
e16fd8a to
4f55851
Compare
838de91 to
fc0f48a
Compare
4f55851 to
92e8726
Compare
fc0f48a to
c49c431
Compare
4cbb2eb to
d15d159
Compare
3a654c0 to
d2947fd
Compare
d2947fd to
0172b97
Compare
…scan - Support cycle_interval in unscan_layers - Raise descriptive ValueError naming the key and missing cycle-slot prefix when slot is None and cycle_interval > 1 - Add unit tests for unscan_layers and inhomogeneous layer cycles
0172b97 to
309aade
Compare
Overview
Part of the stacked Raiden weight-sync enablement PR chain replacing #5089.
Stack:
Details
cycle_intervalinunscan_layersfor models with periodic inhomogeneous layers (e.g. Qwen3.5 GDN).slot is Noneandcycle_interval > 1, raises a descriptiveValueErrornaming the key and the missing cycle-slot prefix instead of misleadingly attributing the failure tonum_layers.tests/unit/raiden_unscan_test.py.Verification
pytest tests/unit/raiden_unscan_test.py(11/11 passed).Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.