Skip to content

[Raiden Weight Sync 5/7] Pass weight_dtype in Qwen3NextSparseMoeBlock shared expert gate - #5170

Merged
copybara-service[bot] merged 1 commit into
mainfrom
yixuann-m5-decoder-unroll
Sep 9, 2026
Merged

[Raiden Weight Sync 5/7] Pass weight_dtype in Qwen3NextSparseMoeBlock shared expert gate#5170
copybara-service[bot] merged 1 commit into
mainfrom
yixuann-m5-decoder-unroll

Conversation

@YixuanWang-99

@YixuanWang-99 YixuanWang-99 commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Overview

Part of the stacked Raiden weight-sync enablement PR chain replacing #5089.

Stack:

Details

  • Fixes shared_expert_gate in Qwen3NextSparseMoeBlock to explicitly pass weight_dtype=cfg.weight_dtype.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Qwen3 model implementation in src/maxtext/models/qwen3.py to explicitly set the weight_dtype parameter to cfg.weight_dtype during the initialization of the shared expert gate. There are no review comments, and I have no additional feedback to provide.

@YixuanWang-99
YixuanWang-99 force-pushed the yixuann-m3-weight-converter branch from 877295e to 9d299ad Compare September 9, 2026 17:56
@YixuanWang-99
YixuanWang-99 force-pushed the yixuann-m5-decoder-unroll branch from 890ab06 to 29e3d54 Compare September 9, 2026 17:56
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SurbhiJainUSC
SurbhiJainUSC changed the base branch from yixuann-m3-weight-converter to main September 9, 2026 18:41
@SurbhiJainUSC
SurbhiJainUSC force-pushed the yixuann-m5-decoder-unroll branch from 29e3d54 to b033d1a Compare September 9, 2026 18:44
@YixuanWang-99
YixuanWang-99 force-pushed the yixuann-m5-decoder-unroll branch 2 times, most recently from 95adff1 to 20f7c50 Compare September 9, 2026 19:13
@YixuanWang-99
YixuanWang-99 changed the base branch from main to yixuann-m3-weight-converter September 9, 2026 19:14
@SurbhiJainUSC
SurbhiJainUSC changed the base branch from yixuann-m3-weight-converter to main September 9, 2026 19:34
@SurbhiJainUSC
SurbhiJainUSC force-pushed the yixuann-m5-decoder-unroll branch from 20f7c50 to 212f591 Compare September 9, 2026 19:37
@copybara-service
copybara-service Bot merged commit b4edf85 into main Sep 9, 2026
61 checks passed
@copybara-service
copybara-service Bot deleted the yixuann-m5-decoder-unroll branch September 9, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants