[Raiden Weight Sync 5/7] Pass weight_dtype in Qwen3NextSparseMoeBlock shared expert gate - #5170
Merged
Merged
Conversation
YixuanWang-99
requested review from
NuojCheng,
RissyRan,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
huytransformer,
igorts-git,
jiangjy1982,
parambole,
richjames0,
shralex,
shuningjin and
xibinliu
as code owners
September 9, 2026 01:22
There was a problem hiding this comment.
Code Review
This pull request updates the Qwen3 model implementation in src/maxtext/models/qwen3.py to explicitly set the weight_dtype parameter to cfg.weight_dtype during the initialization of the shared expert gate. There are no review comments, and I have no additional feedback to provide.
4 tasks
SurbhiJainUSC
approved these changes
Sep 9, 2026
khatwanimohit
approved these changes
Sep 9, 2026
A9isha
approved these changes
Sep 9, 2026
hengtaoguo
approved these changes
Sep 9, 2026
YixuanWang-99
force-pushed
the
yixuann-m3-weight-converter
branch
from
September 9, 2026 17:56
877295e to
9d299ad
Compare
YixuanWang-99
force-pushed
the
yixuann-m5-decoder-unroll
branch
from
September 9, 2026 17:56
890ab06 to
29e3d54
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SurbhiJainUSC
changed the base branch from
yixuann-m3-weight-converter
to
main
September 9, 2026 18:41
SurbhiJainUSC
requested review from
abhinavclemson,
dipannita08 and
vipannalla
as code owners
September 9, 2026 18:41
SurbhiJainUSC
force-pushed
the
yixuann-m5-decoder-unroll
branch
from
September 9, 2026 18:44
29e3d54 to
b033d1a
Compare
YixuanWang-99
force-pushed
the
yixuann-m5-decoder-unroll
branch
2 times, most recently
from
September 9, 2026 19:13
95adff1 to
20f7c50
Compare
YixuanWang-99
changed the base branch from
main
to
yixuann-m3-weight-converter
September 9, 2026 19:14
SurbhiJainUSC
changed the base branch from
yixuann-m3-weight-converter
to
main
September 9, 2026 19:34
SurbhiJainUSC
force-pushed
the
yixuann-m5-decoder-unroll
branch
from
September 9, 2026 19:37
20f7c50 to
212f591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Part of the stacked Raiden weight-sync enablement PR chain replacing #5089.
Stack:
Details
shared_expert_gateinQwen3NextSparseMoeBlockto explicitly passweight_dtype=cfg.weight_dtype.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.