[Raiden Weight Sync 4/7] Target-free and streaming weight conversion for vLLM - #5169
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces target-free weight conversion and streaming weight conversion (convert_streaming) to the MaxText-to-MaxText converter, allowing incremental processing and reduced host memory usage. It also refactors compatibility context management and adds comprehensive unit tests. The review feedback correctly identifies several critical issues where assumptions about self.scan_axis being 1 are hardcoded, which could lead to incorrect shapes or runtime errors if configured differently. Additionally, the feedback points out a risky string prefix check for layer_ that could inadvertently match layers_ and cause crashes, suggesting a safer regex-based approach.
57c2cce to
cea33d1
Compare
877295e to
9d299ad
Compare
0c22cdb to
053be1f
Compare
db7d733 to
b948c90
Compare
e97ce8f to
9e415a2
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
9e415a2 to
28d54bf
Compare
28d54bf to
d7c8aa0
Compare
c16a82f to
3e01530
Compare
eee8f12 to
f21da9e
Compare
f21da9e to
7754d49
Compare
Overview
Part of the stacked Raiden weight-sync enablement PR chain replacing #5089.
Stack:
Details
TargetFreeWeightConverterto convert MaxText weights directly into target vLLM formats without requiring pre-initialized target model structures.tests/post_training/unit/weight_converter_test.py.Verification
pytest tests/post_training/unit/weight_converter_test.py(34/34 passed).Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.