Repository navigation
test(python): make notebook speed-of-light xfail non-strict - #1222
Closed
thekevinbot wants to merge 2 commits into
Closed
thekevinbot wants to merge 2 commits into
thekevinbot wants to merge 2 commits into
Conversation
The test straddles its 1.1x bar locally, so a fast run XPASSes and strict xfail fails e2e attestation for unrelated PRs. skip-changelog: test-only marker change
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
strict=Falseon thexfailmarker ofuse_case_notebook_test.py::describe_notebook_speed_of_light::it_matches_native_rows_within_the_bar. The test hovers around its 1.1x bar, so withstrict=Truea fast run counts as XPASS(strict) and failsjust e2e-attest-pythonfor unrelated PRs. The reason string is unchanged, and the other speed-of-light tests are untouched.Fixes #1221
Related: #1202
Changelog / Migrations
<root>/<pkg>/changelog.d/for each changed package (or:skip-changelogtrailer on a commit with reason): test-only, so the file is exempt; askip-changelog:line is also on the commit<root>/<pkg>/migrations.d/(or: not required -- additive/bugfix only): not requiredE2E Verification
packages/python/e2e-attestations/<branch>.jsonreceipt written ifpackages/pythonchanged (just e2e-attest-python)packages/ts/e2e-attestations/<branch>.jsonreceipt written ifpackages/tschanged (just e2e-attest-ts): N/Acargo build -p dirsql --features cli,just e2e-attest-python