Repository navigation
config: re-pin the rust coverage floors to current actuals - #1147
Merged
Merged
Conversation
Measured on 59474c3 with `cargo +nightly llvm-cov --lib --features cli --branch`: lines 94.54, regions 93.67, functions 93.16, branch 79.49. Each floor moves to the highest integer strictly under its actual, per the rule the file's own header states, leaving under a point of slack on every dimension again. No test is added, deleted, or weakened; this measures the tree as it already is. The sub-90 `branch` exception is unchanged in kind -- 72 simply left seven points unguarded. skip-changelog: config-only, no shipped behavior change Fixes #1136
The rationale for the upward move lives in the PR body; the file keeps the fresh actuals and one line on direction. skip-changelog: config comment only, no shipped behavior change
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins
[rust.coverage]to the tree's actual coverage. The floors had drifted2-7 points under, which is not a ratchet: a PR could delete a meaningful amount
of covered branch logic and the gate would stay green.
Fixes #1136
Measured on
59474c3(currentmain) frompackages/rustwithcargo +nightly llvm-cov --lib --features cli --branch. Fresh numbers, not theones in the issue body: #1146 and #1141 landed after those were taken, and
branchcame out at 79.49 rather than 80.06.Each floor is the highest integer strictly under its actual, per the rule the
file's own header states. No dimension was softened to buy slack. The in-file
comment records the fresh actuals and explains why the numbers moved up for
once: the recent refactors pulled pure logic out of the effectful modules the
unit tier cannot reach and into wholly unit-testable ones (
extension_resolution.rs,row_event_flat.rs,path_table.rs), which lifts the numerator and, forbranch, adds fully-covered branch regions to the denominator.The sub-90
branchexception is unchanged in kind — 79 is still short of theFragility is reintroduced deliberately: with under a
point of slack everywhere, a PR that merely adds well-formed unit tests can
lower
branchand trip the floor, and the fix then is to nudge that floor downto the new actual.
No test added, deleted, or weakened.
[python.coverage],[e2e], and[rust].featuresuntouched.Verification
npx testing-conventions unit coverage --language rustcannot run locally — itresolves the stable toolchain regardless of
RUSTUP_TOOLCHAIN, and--branchneeds nightly.
just preflightdoes not cover this gate either (it is thebespoke
Rust unit coverage floorjob indirsql-rust-ci.yml), so CI on thisPR is the real verification.
just preflightwas run anyway on the committeddiff:
0 failing pair(s), 3 skipped.E2E Verification
N/A - CI/config only
Changelog / Migrations
skip-changelogon the commit)