Repository navigation
config: drop the stale rust floor copy from the toml header - #1153
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root
testing-conventions.tomlheader restated the rust coverage floorsabout 145 lines above the block that assigns them, and the copy had drifted:
it said
lines 94 / regions 93 / functions 91 / branch 75while the livevalues are
94 / 93 / 93 / 79(#1147). Removed the parenthetical — thesentence reads fine without it and the assignments are in the same file.
Same fix #1150 applied to
AGENTS.mdandagents/reference/testing-gates.md.The #354 derivation narration keeps its numbers (they are historical
actuals, not a claim about the current config); one word of tense —
"The floors below are then set" → "The floors were then set" — so a reader
cannot read it as describing the values below.
Fixes #1151
E2E Verification
N/A - CI/config only
Changelog / Migrations
<root>/<pkg>/changelog.d/for each changed package (or:skip-changelogtrailer on a commit with reason) —skip-changelog: config comment only, no observable change<root>/<pkg>/migrations.d/(or: not required -- additive/bugfix only) — not required