Limit Candlepin heap in development tuning - #865
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughDevelopment tuning now sets Candlepin Java’s minimum heap to ChangesCandlepin heap tuning
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~7 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The affected CI jobs use the reduced development heap settings. The 2g maximum is not proof that the historical memory failure is impossible, but no current failure is established; merge risk is minimal based on available evidence. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM |
Both IOP-enabled CI matrices exhausted the VM memory and the kernel killed Candlepin while it was holding about 1.2 GiB RSS. The development tuning profile inherited the production Candlepin heap defaults of 1 GiB initial and 4 GiB maximum.
Use a 512 MiB initial heap and 2 GiB maximum for development deployments, including the CI matrix, and cover the tuning values with a unit test. Production tuning profiles remain unchanged.
Fixes #864
Tested: