Conversation
|
Warning Review limit reachedNext included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The failing deployment job is caused by the shared development-memory issue, not by the auth-bundle output change: Candlepin is killed by the OOM killer. #865 contains the fix and has passed the complete CI matrix. |
| - role: auth_bundle | ||
| vars: | ||
| auth_bundle_hostname: "{{ hostname }}" | ||
| auth_bundle_proxy_flavor: >- |
There was a problem hiding this comment.
I don't like this baking of the flavor into the playbooks if we can help it.
| Then run this command on {{ auth_bundle_hostname }}: | ||
|
|
||
| foremanctl deploy-proxy \ | ||
| --flavor {{ auth_bundle_proxy_flavor | quote }} \ |
There was a problem hiding this comment.
I wonder if we can have a mechanism by which to mark a flavor as the default or as the primary, then having someway that vendor overrides can set this and make the command less reliant on flavor directly. Just an idle thought.
| msg: | | ||
| Auth bundle created: {{ _bundle_path }} | ||
|
|
||
| To finish the proxy installation, copy the bundle to the proxy: |
There was a problem hiding this comment.
I've previously wondered about making this output less specific and more like:
Next steps:
1. Transfer auth bundle securely
2. Run `deploy-proxy` command with these options
2 participants
Why are you introducing these changes? (Problem description, related links)
auth-bundle currently reports only the generated archive path. Users still have to reconstruct the scp and deploy-proxy commands, including both hostnames, by hand.
Fixes #812
What are the changes introduced in this pull request?
How to test this pull request
Checklist
This pull request was created with assistance from OpenAI Codex.