Skip to content

Skip Foreman task checks on proxy backups - #860

Open
jakduch wants to merge 1 commit into
theforeman:masterfrom
jakduch:fix/790-proxy-backup-tasks
Open

jakduch wants to merge 1 commit into
theforeman:masterfrom
jakduch:fix/790-proxy-backup-tasks

Conversation

@jakduch

@jakduch jakduch commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • run Foreman task preflight checks only on hosts with the foreman feature
  • keep Pulp task checks enabled for content proxy backups
  • document the server/proxy distinction and guard it with a regression test

Testing

  • ansible-lint src/roles/backup
  • targeted feature-guard regression test
  • git diff --check

Fixes #790

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: b3648e20-c082-4b04-9fb6-a2c1793448c0

📥 Commits

Reviewing files that changed from the base of the PR and between acdb0f7 and 8c95876.

📒 Files selected for processing (3)
  • docs/user/backup-restore.md
  • src/roles/backup/tasks/preflight.yaml
  • tests/unit/check_role_test.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jakduch

jakduch commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

The timer failures are outside this proxy-backup change and occur under the same resource pressure that killed services in the shared CI runs. #865 limits the Candlepin heap for development tuning and has passed the complete CI matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip waiting for foreman task on proxy backup.

1 participant