Skip to content

Automatic mode #8

Closed
Closed

Description

@ribeirogab

Parent

#1

What to build

Reviewers can choose automatic mode on the Settings page, so that their rules apply in every pull request as soon as the Files changed page opens.

Acceptance criteria

  • The General section offers Manual (the default) and Automatic, each with its explanation.
  • In automatic mode, opening the Files changed page hides matching files at once, without an activation, and the control shows the Automatic label.
  • In automatic mode the menu has no pull request switch. Show all files pauses filtering for the current view only, and a reload hides the files again.
  • Switching back to manual mode uses the stored activations again.
  • When no rule is on, the menu's empty state explains automatic mode.

Blocked by

Activity

  1. self-assigned this
    on Oct 2, 2026
  2. ribeirogab commented on Oct 2, 2026

    @ribeirogab
    OwnerAuthor

    Update: the implementation was reverted in a619cac. This issue is reopened and its acceptance criteria are unchecked.

    Built Manual and Automatic activation controls, automatic filtering and its label, mode-specific menu copy, and session-only Show all files. Switching back to manual mode restores the stored activations. All 44 unit tests and 15 end-to-end tests passed.

    Validation: pnpm check, pnpm typecheck, pnpm test (unit and fixture-routed Chromium end-to-end suites), and pnpm build passed.

    Commit: f639483. No acceptance criteria deferred.

  3. ribeirogab commented on Oct 3, 2026

    @ribeirogab
    OwnerAuthor

    Built automatic mode. The General section offers Manual (with the Default label) and Automatic, each with the prototype's explanation. In automatic mode filtering is active as soon as the Files changed page opens, without storing an activation; the control shows the accent Automatic label inside the button, the menu header shows Automatic, the pull request switch is gone, and Show all files says Temporarily. Automatic mode stays on. Show all files pauses filtering for the current view only, and a reload hides the files again. Changing the activation mode ends a pause; switching back to manual uses the stored activations again (they are never removed in automatic mode). With no rule on, the empty menu explains automatic mode.

    Tests:

    • End to end: 5 new tests (General choices and storage, automatic filtering on PR 1 and PR 2 without activations, Show all files lifetime, switching back to manual with stored activations while a pull request is open, empty-state copy).
    • Visual: automatic control (rest, keyboard focus, showing all), automatic menu (filtering, showing all, empty), and the General section in automatic mode, in light and dark at zero different pixels.

    Commit: 4e0b100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ready-for-agentFully specified; an agent can pick it up

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions