You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update: the implementation was reverted in a619cac. This issue is reopened and its acceptance criteria are unchecked.
Built Manual and Automatic activation controls, automatic filtering and its label, mode-specific menu copy, and session-only Show all files. Switching back to manual mode restores the stored activations. All 44 unit tests and 15 end-to-end tests passed.
Validation: pnpm check, pnpm typecheck, pnpm test (unit and fixture-routed Chromium end-to-end suites), and pnpm build passed.
Built automatic mode. The General section offers Manual (with the Default label) and Automatic, each with the prototype's explanation. In automatic mode filtering is active as soon as the Files changed page opens, without storing an activation; the control shows the accent Automatic label inside the button, the menu header shows Automatic, the pull request switch is gone, and Show all files says Temporarily. Automatic mode stays on. Show all files pauses filtering for the current view only, and a reload hides the files again. Changing the activation mode ends a pause; switching back to manual uses the stored activations again (they are never removed in automatic mode). With no rule on, the empty menu explains automatic mode.
Tests:
End to end: 5 new tests (General choices and storage, automatic filtering on PR 1 and PR 2 without activations, Show all files lifetime, switching back to manual with stored activations while a pull request is open, empty-state copy).
Visual: automatic control (rest, keyboard focus, showing all), automatic menu (filtering, showing all, empty), and the General section in automatic mode, in light and dark at zero different pixels.
Activity
ribeirogab commentedon Oct 2, 2026
Update: the implementation was reverted in a619cac. This issue is reopened and its acceptance criteria are unchecked.
Built Manual and Automatic activation controls, automatic filtering and its label, mode-specific menu copy, and session-only Show all files. Switching back to manual mode restores the stored activations. All 44 unit tests and 15 end-to-end tests passed.
Validation: pnpm check, pnpm typecheck, pnpm test (unit and fixture-routed Chromium end-to-end suites), and pnpm build passed.
Commit: f639483. No acceptance criteria deferred.
ribeirogab commentedon Oct 3, 2026
Built automatic mode. The General section offers Manual (with the Default label) and Automatic, each with the prototype's explanation. In automatic mode filtering is active as soon as the Files changed page opens, without storing an activation; the control shows the accent
Automaticlabel inside the button, the menu header showsAutomatic, the pull request switch is gone, andShow all filessaysTemporarily. Automatic mode stays on.Show all files pauses filtering for the current view only, and a reload hides the files again. Changing the activation mode ends a pause; switching back to manual uses the stored activations again (they are never removed in automatic mode). With no rule on, the empty menu explains automatic mode.Tests:
Commit: 4e0b100.