Repository navigation
Show all files and the all-hidden empty state #5
Description
Parent
What to build
While filtering, a reviewer can show all files for the current view and hide them again in one click, without changing rules, activation, or activation mode. When every listed file is hidden, the diff and the tree explain why and offer a way out.
Acceptance criteria
-
Show all filesin the menu shows every file, and the control becomes the split buttonHide files againwith the number of matching files. -
Hide files againrestores filtering. - Show all files ends on reload or when the user leaves the pull request. Rules, activation, and activation mode do not change.
- When every listed file is hidden, the diff shows the empty state with
Show all filesandEdit rules, the tree shows its empty note, and the control stays available. - Each state change is announced once.
Activity
ribeirogab commentedon Oct 2, 2026
Update: the implementation was reverted in a619cac. This issue is reopened and its acceptance criteria are unchecked.
Built session-only Show all files, Hide files again, accessible announcements, and all-hidden diff and sidebar tree states with recovery actions. Validation includes 41 unit tests and 10 end-to-end tests.
Validation: pnpm check, pnpm typecheck, pnpm test (unit and fixture-routed Chromium end-to-end suites), and pnpm build passed.
Commit: 285560f. No acceptance criteria deferred.
ribeirogab commentedon Oct 2, 2026
Built session-only Show all files: the menu item shows every file and turns the control into the split button
Hide files againwith the matching count;Hide files again(button or menu item) restores filtering. The pause lives in memory only, so a reload or leaving the pull request ends it, and rules, activation, and activation mode do not change. When every listed file is hidden, the diff shows the empty state (All files are hiddenorAll other files are hiddenwhen Always show rules keep files) withShow all filesandEdit rules, the sidebar tree shows its empty note, and the control stays available. Each state change is announced once.Tests:
Edit rulesopens the Settings page section with the most hiding rules; its end-to-end test lands with the Settings page in #6.Commit: 0bd361b.