Settings page with presets #6

Activity

1. ribeirogab

   added

   ready-for-agentFully specified; an agent can pick it upFully specified; an agent can pick it up

   on Oct 2, 2026
2. ribeirogab

   added a parent issue on Oct 2, 2026

   • Spec: GitHub File Hider first version #1
3. ribeirogab

   marked this as blocked on Oct 2, 2026

   • Hide preset files in manual mode #4
4. ribeirogab

   marked this as blocking 3 issues on Oct 2, 2026

   • Custom rules and Always show rules #7
   • Automatic mode #8
   • Tree filtering off #10
5. ribeirogab

   self-assigned this

   on Oct 2, 2026
6. ribeirogab commented on Oct 2, 2026

   

   ribeirogab

   on Oct 2, 2026

   Last edited by ribeirogab

   OwnerAuthor

   More actions

   Update: the implementation was reverted in a619cac. This issue is reopened and its acceptance criteria are unchecked.

   Built the full-tab Settings page, editable presets with validation and Restore defaults, local storage notifications, keyboard editing, theme support, and scope/privacy copy. Chromium end-to-end tests exercise both the menu and the real extension action through the browser protocol. 44 unit tests and 12 end-to-end tests passed.

   Validation: pnpm check, pnpm typecheck, pnpm test (unit and fixture-routed Chromium end-to-end suites), and pnpm build passed.

   Commit: 6cf0a8d. No acceptance criteria deferred.
7. ribeirogab

   closed this as completedon Oct 2, 2026
8. ribeirogab

   reopened this on Oct 2, 2026
9. ribeirogab commented on Oct 2, 2026

   

   ribeirogab

   on Oct 2, 2026

   OwnerAuthor

   More actions

   Built the full-tab Settings page (settings.html, options_ui with open_in_tab), ported from the prototype's Settings screen without its prototype bar and fake browser bar. The extension icon opens it through the service worker (no popup, nothing opens on install), and the menu's Settings and Custom rules items and the empty state's Edit rules open it in a new tab at the right section. The page states the scope and storage facts and that GitHub File Hider is not affiliated with GitHub.

   Each preset has its own switch, a rule list with add, edit, and remove, validation messages (empty, leading /, backslash, ***, duplicate), the Modified label, and Restore defaults (disabled with a tooltip when the rules match the defaults). Stored rules exist only while they differ from the installed defaults (ADR 0003, covered by unit tests). Every change is written to chrome.storage.local and reaches open pull request tabs without a reload. The page follows the prototype's keyboard behavior (focus restoration after edits, Esc cancels an edit) and the system light or dark theme.

   The page frame already includes the Custom rules and Always show sections and the General choices from the prototype; their behavior is verified in #7, #8, and #10.

   Tests:

   • End to end: 10 new tests (no page on install, the real extension action via the browser protocol, menu Settings, Edit rules, scope and disclaimer copy, preset switches, rule editing with every validation message, Restore defaults, live update of an open pull request, keyboard use).
   • Visual: 25 Settings scenes in light and dark (General, Presets, Custom rules, Always show, first install, modified, editing, edit and add errors, disabled Restore tooltip, rule hover, empty preset, empty lists, syntax help, saved indicator, focus and hover states) at zero different pixels. Total: 114 visual comparisons.

   Commit: e05f7a0.
10. ribeirogab

    closed this as completedon Oct 2, 2026
11. ribeirogab commented on Oct 3, 2026

    

    ribeirogab

    on Oct 3, 2026

    OwnerAuthor

    More actions

    Follow-up: the build script change that bundles settings-page.js, settings.css, settings.html and registers options_ui was missing from e05f7a0 and landed in 5fe0ee7. The tests ran against the complete working tree, so their results stand.