Skip to content

chore(ci): replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet - #5820

Merged
openshift-merge-bot[bot] merged 4 commits into
redhat-developer:mainfrom
zdrapela:rhdhbugs-4113-replace-crunchy
Nov 12, 2026
Merged

openshift-merge-bot[bot] merged 4 commits into
redhat-developer:mainfrom
zdrapela:rhdhbugs-4113-replace-crunchy

Conversation

@zdrapela

@zdrapela zdrapela commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Jira: https://redhat.atlassian.net/browse/RHDHBUGS-4113

The Crunchy Postgres operator is not in the OCP 5.0 certified-operators catalog, so the OCP jobs fail during cluster setup, and Crunchy's Developer Program images (used by our PostgresCluster) stop receiving updates on 2026-12-31.

This replaces the external PostgreSQL used by showcase-rbac with a plain StatefulSet running registry.redhat.io/rhel9/postgresql-18, keeping the Service names the RBAC values already expect, so the chart and test code stay unchanged:

  • TLS cert generated by the CI script (CA + server cert with SANs for the Service DNS names), stored in the same postgress-external-db-cluster-cert secret the RBAC values mount.
  • pg_hba.rules loaded through hba_file: the unix socket is trusted for the image's start hooks, and every TCP client (including oc port-forward, which arrives over loopback) needs TLS and a password. ssl_groups is pinned to prime256v1 for FIPS clusters.
  • Start hook creates the rhdh SUPERUSER from postgress-external-db-pguser-rhdh, so role creation never depends on the image's authentication defaults.
  • registry.redhat.io pull secret created from the existing REGISTRY_REDHAT_IO_SERVICE_ACCOUNT_DOCKERCONFIGJSON CI secret.
  • Removed: Crunchy operator install, PostgresCluster CRD waits, unused OLM Subscription helpers, empty cluster_setup_ocp_* hooks.
  • Renamed the external DB TLS spec, the admin user (janus-idp -> rhdh) and updated the CI docs.

Validated locally with podman, including an arbitrary UID run: plaintext loopback connections are rejected, TLS + password connects, rhdh is a superuser, the readiness probe reports healthy with the TLS-only rules, and the data dir is on the PVC.

@openshift-ci

openshift-ci Bot commented Nov 11, 2026

Copy link
Copy Markdown

@zdrapela: GitHub didn't allow me to request PR reviews from the following users: redhat-developer/rhdh-qe.

Note that only redhat-developer members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Jira: https://redhat.atlassian.net/browse/RHDHBUGS-4113

The Crunchy Postgres operator is not in the OCP 5.0 certified-operators catalog, so the OCP jobs fail during cluster setup, and Crunchy's Developer Program images (used by our PostgresCluster) stop receiving updates on 2026-12-31.

This replaces the external PostgreSQL used by showcase-rbac with a plain StatefulSet running registry.redhat.io/rhel9/postgresql-18:

  • TLS cert generated by the CI script (CA + server cert with SANs for the Service DNS names), stored in the same postgress-external-db-cluster-cert secret the RBAC values mount.
  • Start hook enforces TLS for network connections and creates the janus-idp SUPERUSER.
  • registry.redhat.io pull secret created from the existing REGISTRY_REDHAT_IO_SERVICE_ACCOUNT_DOCKERCONFIGJSON CI secret.
  • Removed: Crunchy operator install, PostgresCluster CRD waits, unused OLM Subscription helpers, empty cluster_setup_ocp_* hooks.
  • Renamed the external DB TLS spec and updated the CI docs.

Validated locally with podman, including an arbitrary UID run: TLS-only connection works, janus-idp is a superuser, data dir is on the PVC.

/cc @redhat-developer/rhdh-qe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zdrapela

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@zdrapela

Copy link
Copy Markdown
Member Author

/test e2e-ocp-v5-0-helm-nightly

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Replace Crunchy PostgreSQL with a RHEL StatefulSet in OCP CI

🐞 Bug fix ✨ Enhancement 🕐 40+ Minutes

Grey Divider

AI Description

• Replace the unavailable Crunchy operator with RHEL PostgreSQL to restore OCP CI setup.
• Provision TLS, credentials, image-pull access, and persistent storage for the external RBAC
 database.
• Remove Crunchy-specific setup and align schema-mode discovery, tests, and documentation.
Diagram

graph TD
  CI["OCP jobs"] --> Setup["DB setup"] --> Secrets["DB secrets"] --> DB["PostgreSQL StatefulSet"] --> Service["Primary Service"] --> RBAC["RBAC deployment"] --> Tests["E2E tests"]
  Setup --> DB
  DB --> PVC[("Data PVC")]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Use another supported PostgreSQL operator
  • ➕ Could retain operator-managed backups and database lifecycle features.
  • ➖ Introduces another catalog dependency and more setup complexity for CI.
2. Use the bundled database
  • ➕ Requires less external database provisioning.
  • ➖ Would not exercise the external PostgreSQL and TLS configuration used by showcase-rbac.

Recommendation: Keep the StatefulSet for this CI-only external database: it removes the unavailable Crunchy catalog dependency while preserving the external TLS test path. The loss of operator-managed backups is a trade-off worth revisiting if this database becomes long-lived.

Files changed (20) +279 / -286

Enhancement (1) +8 / -8
schema-mode-env.shDiscover the external PostgreSQL pod for schema tests +8/-8

Discover the external PostgreSQL pod for schema tests

• Replaces Crunchy-specific names and pod labels with the StatefulSet label and an external database name override. Continues to read the admin password from the compatible user secret.

.ci/pipelines/lib/schema-mode-env.sh

Bug fix (7) +2 / -29
operator.shRemove Crunchy checks from RHDH operator deployment +2/-17

Remove Crunchy checks from RHDH operator deployment

• Drops the PostgresCluster CRD wait and debug query. Database-resource readiness now checks the operator-created StatefulSet only.

.ci/pipelines/install-methods/operator.sh

ocp-fips-helm.shSkip obsolete OCP FIPS cluster setup +0/-2

Skip obsolete OCP FIPS cluster setup

• Removes the cluster setup call that previously installed Crunchy.

.ci/pipelines/jobs/ocp-fips-helm.sh

ocp-localization.shSkip obsolete localization cluster setup +0/-1

Skip obsolete localization cluster setup

• Removes the Crunchy-dependent setup call before deployment.

.ci/pipelines/jobs/ocp-localization.sh

ocp-nightly.shSkip obsolete nightly cluster setup +0/-2

Skip obsolete nightly cluster setup

• Removes the OCP Helm setup call that installed Crunchy.

.ci/pipelines/jobs/ocp-nightly.sh

ocp-operator.shRemove Crunchy prerequisites from operator jobs +0/-4

Remove Crunchy prerequisites from operator jobs

• Drops PostgresCluster CRD waits for RBAC deployments and the obsolete OCP operator cluster setup call.

.ci/pipelines/jobs/ocp-operator.sh

ocp-pull.shSkip obsolete pull-job cluster setup +0/-1

Skip obsolete pull-job cluster setup

• Removes the OCP Helm setup call before showcase deployments.

.ci/pipelines/jobs/ocp-pull.sh

upgrade.shSkip obsolete upgrade-job cluster setup +0/-2

Skip obsolete upgrade-job cluster setup

• Removes the Crunchy-dependent setup call before the Helm upgrade baseline.

.ci/pipelines/jobs/upgrade.sh

Refactor (1) +0 / -63
operators.shRemove Crunchy and unused Subscription helpers +0/-63

Remove Crunchy and unused Subscription helpers

• Deletes Crunchy installation, Subscription creation, and operator-status polling utilities. Tekton and OLM utilities remain.

.ci/pipelines/lib/operators.sh

Tests (2) +6 / -6
playwright.config.tsRetarget Playwright projects to the renamed TLS spec +5/-5

Retarget Playwright projects to the renamed TLS spec

• Updates project inclusion and exclusion patterns so the external PostgreSQL TLS spec runs in the intended RBAC project.

e2e-tests/playwright.config.ts

verify-tls-config-with-external-postgres.spec.tsRename the external database connectivity spec +1/-1

Rename the external database connectivity spec

• Renames the Crunchy-specific spec and suite to external PostgreSQL. The existing database-backed UI assertion is unchanged.

e2e-tests/playwright/e2e/external-database/verify-tls-config-with-external-postgres.spec.ts

Documentation (7) +13 / -15
README.mdRefresh operator utility documentation +2/-3

Refresh operator utility documentation

• Replaces references to removed PostgreSQL installer helpers with the remaining Tekton installation helper.

.ci/pipelines/lib/README.md

diff-values_showcase-rbac_AKS.yamlClarify AKS external database TLS comment +1/-1

Clarify AKS external database TLS comment

• Updates the explanation for removing external database SSL settings when using the bundled Kubernetes database.

.ci/pipelines/value_files/diff-values_showcase-rbac_AKS.yaml

diff-values_showcase-rbac_EKS.yamlClarify EKS external database TLS comment +1/-1

Clarify EKS external database TLS comment

• Replaces the Crunchy reference in the comment explaining why bundled-database SSL settings are removed.

.ci/pipelines/value_files/diff-values_showcase-rbac_EKS.yaml

diff-values_showcase-rbac_GKE.yamlClarify GKE external database TLS comment +1/-1

Clarify GKE external database TLS comment

• Updates the bundled-database SSL comment to refer to external PostgreSQL rather than Crunchy.

.ci/pipelines/value_files/diff-values_showcase-rbac_GKE.yaml

CI-medic-guide.mdUpdate CI troubleshooting for external PostgreSQL +2/-3

Update CI troubleshooting for external PostgreSQL

• Removes Crunchy installation guidance and documents StatefulSet readiness failures and schema-mode use of the replacement database.

docs/e2e-tests/CI-medic-guide.md

layer-migration-matrix.mdRename the external database test entry +1/-1

Rename the external database test entry

• Identifies the external database test as PostgreSQL rather than Crunchy and names RHEL PostgreSQL as its dependency.

docs/e2e-tests/layer-migration-matrix.md

README.mdDocument StatefulSet schema-mode discovery +5/-5

Document StatefulSet schema-mode discovery

• Explains the new database name override, user secret, and labeled pod used for port-forwarding. Clarifies that the external PostgreSQL server requires TLS.

e2e-tests/playwright/e2e/plugin-division-mode-schema/README.md

Other (2) +250 / -165
postgres.yamlDefine the RHEL PostgreSQL external database +157/-64

Define the RHEL PostgreSQL external database

• Replaces the PostgresCluster with TLS and startup ConfigMaps, a Service, and a single-replica StatefulSet backed by a PVC. The startup hook restricts network connections to TLS and creates the janus-idp superuser; operator-managed backup resources are removed.

.ci/pipelines/resources/postgres-db/postgres.yaml

utils.shProvision the StatefulSet and its connection secrets +93/-101

Provision the StatefulSet and its connection secrets

• Generates a CA and Service-DNS server certificate, creates or reuses TLS and user secrets, and provisions registry pull access. Deploys and waits for PostgreSQL, then copies certificate material and connection credentials to the RBAC namespace; removes Crunchy setup wrappers.

.ci/pipelines/utils.sh

@zdrapela
zdrapela force-pushed the rhdhbugs-4113-replace-crunchy branch from 77549f7 to 5dbe654 Compare November 11, 2026 15:08
@zdrapela zdrapela changed the title ci: replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet chore(ci): replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet Nov 11, 2026
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.33%. Comparing base (5eddd5b) to head (d6b9712).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5820      +/-   ##
==========================================
- Coverage   78.97%   73.33%   -5.65%     
==========================================
  Files          66       59       -7     
  Lines         723      570     -153     
  Branches      100       83      -17     
==========================================
- Hits          571      418     -153     
  Misses        151      151              
  Partials        1        1              
Flag Coverage Δ
rhdh 69.38% <ø> (-6.65%) ⬇️
rhdh-e2e-frontend 71.23% <ø> (ø)
Components Coverage Δ
Backend plugins ∅ <ø> (∅)
Backend app 79.91% <ø> (ø)
Frontend app 68.40% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eddd5b...d6b9712. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zdrapela

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@github-actions

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@zdrapela

Copy link
Copy Markdown
Member Author

/test e2e-ocp-v5-0-helm-nightly

@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Code Review by Qodo


Action required

1. Existing database secrets block startup 🐞 Bug
Description
configure_external_postgres_db reuses any existing user secret, but the new StatefulSet requires a
postgres-password key that the old Crunchy-generated user secret was not required to contain. When
the helper runs in a namespace with the previous database, PostgreSQL cannot resolve its required
environment variable and the rollout cannot complete.
Code

.ci/pipelines/utils.sh[R252-254]

+  if oc get secret "${user_secret}" -n "${db_namespace}" &> /dev/null; then
+    log::info "Reusing existing ${user_secret} secret"
+  elif ! oc create secret generic "${user_secret}" \
Relevance

●● Moderate

Concrete secret-reuse bug, but the team's handling of existing-secret/migration cases is not
established in history.

PR-#5709

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The helper unconditionally reuses a secret if it exists, while the replacement pod requires the
newly introduced postgres-password key. The prior deployment declared an operator-managed
janus-idp user, and the prior helper consumed its password key without creating an
admin-password key.

.ci/pipelines/utils.sh[232-260]
.ci/pipelines/resources/postgres-db/postgres.yaml[100-115]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
An existing Crunchy user secret can lack the new `postgres-password` key, preventing the StatefulSet container from starting.
## Fix Focus Areas
- .ci/pipelines/utils.sh[252-260]
- .ci/pipelines/resources/postgres-db/postgres.yaml[100-115]
## Recommended Fix
Check the keys of an existing user secret before reuse. Supply a persistent PostgreSQL admin password through a compatible secret or explicitly migrate the secret before creating the StatefulSet; preserve existing application credentials.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


View medium (1)
Remediation recommended
2. Existing databases start with empty data 🐞 Bug
Description
The new volumeClaimTemplates creates a StatefulSet-owned claim rather than attaching or migrating
the volume managed by the old PostgresCluster. If this deployment runs in an existing database
namespace, oc apply leaves the old resource in place and starts a separate PostgreSQL instance
with a fresh data directory.
Code

.ci/pipelines/resources/postgres-db/postgres.yaml[R159-161]

+  volumeClaimTemplates:
+    - metadata:
+        name: data
Relevance

●● Moderate

Data migration concern from replacing the operator-managed PostgresCluster is architectural; no
close precedent either way.

PR-#4414

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The new claim template provisions storage for the replacement StatefulSet, while the deployment
helper only applies the new manifest and waits for its rollout. Applying a manifest does not remove
the old, separately managed PostgresCluster or transfer its stored data.

.ci/pipelines/resources/postgres-db/postgres.yaml[159-167]
.ci/pipelines/utils.sh[263-273]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Applying the replacement manifest to an existing Crunchy namespace neither migrates its data nor removes its managed resources.
## Fix Focus Areas
- .ci/pipelines/resources/postgres-db/postgres.yaml[159-167]
- .ci/pipelines/utils.sh[263-269]
## Recommended Fix
Before applying the StatefulSet, detect an existing PostgresCluster and either stop with a clear migration requirement or provide an explicit, tested migration and cleanup path. Do not silently provision a new empty database.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


View low (2)
Informational
3. CA private key left on disk when setup fails 🐞 Bug ⭐ New
Description
configure_external_postgres_db writes the CA key, server key and CSR into a mktemp -d directory
but only runs rm -rf "${cert_dir}" after the last secret is created. Every earlier return 1
(cert generation, secret creation, oc apply, rollout timeout, oc extract) leaves the directory
and its ca.key/tls.key behind in the runner's temp space.
Code

.ci/pipelines/utils.sh[R226-227]

+  local cert_dir
+  cert_dir=$(mktemp -d)
Relevance

●●● Strong

Closest precedent: PR #5579 accepted an EXIT trap to remove a mktemp cert dir in the CI FIPS job;
temp-dir cleanup on error paths is a trivial, accepted reliability fix. No dismissals or close
rejections found.

PR-#5579
PR-#4679
PR-#3737

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The temp dir is created at line 227. The only cleanup is at line 300, after the final secret apply.
Error paths at lines 242, 250, 262, 268, 276, 282, 291 and 298 all return without removing it.

.ci/pipelines/utils.sh[226-301]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`configure_external_postgres_db` only deletes its temp cert directory, which holds the CA and server private keys, on the success path. Early returns leave it behind.

## Fix Focus Areas
- .ci/pipelines/utils.sh[226-301]

## Recommended Fix
Right after `cert_dir=$(mktemp -d)`, add `trap 'rm -rf "${cert_dir}"; trap - RETURN' RETURN` (or wrap the body so cleanup runs on every exit), then remove the trailing `rm -rf "${cert_dir}"`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

4. External DB image floats on the latest tag 🐞 Bug
Description
The StatefulSet and its init container use registry.redhat.io/rhel9/postgresql-18:latest, while
the Crunchy manifest it replaces pinned an exact build (ubi9-18.1-2547). Any image rebuild,
including changes to the start-hook contract, the generated pg_hba.conf or check-container,
reaches every CI run with no repo change, which makes failures hard to bisect and runs hard to
reproduce.
Code

.ci/pipelines/resources/postgres-db/postgres.yaml[96]

+          image: registry.redhat.io/rhel9/postgresql-18:latest
Relevance

●● Moderate

Pinning floating image tags is a similar past request (Codecov pinning) that was rejected, but that
rejection is about six months old and weak evidence.

PR-#4798

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
Both containers reference the mutable :latest tag. The start hook's sed depends on the
image-generated pg_hba.conf keeping the exact host all all all md5 line, so a silent image
change can quietly turn off TLS enforcement or break startup.

.ci/pipelines/resources/postgres-db/postgres.yaml[20-28]
.ci/pipelines/resources/postgres-db/postgres.yaml[67-97]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The external PostgreSQL manifest uses the mutable `registry.redhat.io/rhel9/postgresql-18:latest` tag in two places.

## Fix Focus Areas
- .ci/pipelines/resources/postgres-db/postgres.yaml[71-71]
- .ci/pipelines/resources/postgres-db/postgres.yaml[96-96]

## Recommended Fix
Replace `:latest` with a specific versioned tag or a sha256 digest in both the init container and the main container, and bump it on purpose when needed.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@zdrapela

Copy link
Copy Markdown
Member Author

/test e2e-ocp-v5-0-helm-nightly

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@zdrapela

Copy link
Copy Markdown
Member Author

/agentic_review

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

…tefulSet

The Crunchy Postgres operator is not available in the OCP 5.0
certified-operators catalog (crunchy-postgres-operator is published for
OCP 4.15-4.22 only), so every OCP job fails before the tests start. On top
of that, Crunchy announced that the Developer Program images our
PostgresCluster pulls will stop receiving updates on 2026-12-31.

Deploy the external PostgreSQL used by showcase-rbac as a plain
StatefulSet running registry.redhat.io/rhel9/postgresql-18 instead:

- TLS server certificate generated by the CI script (CA + cert with SANs
  for the Service DNS names), served from the same
  postgress-external-db-cluster-cert secret the RBAC values mount.
- The start hook restricts network connections to TLS and creates the
  janus-idp SUPERUSER from postgress-external-db-pguser-janus-idp.
- The registry.redhat.io pull secret is created from the existing
  REGISTRY_REDHAT_IO_SERVICE_ACCOUNT_DOCKERCONFIGJSON CI secret.

The Crunchy operator install, the PostgresCluster CRD waits and the OLM
Subscription helpers (only used for Crunchy) are removed, together with
the now empty cluster_setup_ocp_* hooks. Also rename the external DB TLS
spec and update the CI docs accordingly.

Jira: https://redhat.atlassian.net/browse/RHDHBUGS-4113
Assisted-by: OpenCode
- Replace the pg_hba.conf rewrite in the start hook with declarative
  pg_hba.rules loaded through hba_file, so TLS-only enforcement no longer
  depends on the authentication lines generated by the image
- Set ssl_groups to prime256v1, since the PostgreSQL 18 default
  (X25519:prime256v1) is not FIPS-approved
- Extract the certificates with oc extract and fail on empty passwords
  instead of publishing empty secrets
- Propagate configure_external_postgres_db failures and drop the
  redundant StatefulSet wait in rbac_deployment
- Drop the unused SCHEMA_MODE_EXTERNAL_DB_NAME override and refresh the
  CI docs, the pr-triage skill and the pgdb catalog entry

Assisted-by: OpenCode
The janus-idp user name is a leftover from the Crunchy operator user spec
and no longer describes the database used by CI. Rename the user and the
secret that carries its credentials.

Assisted-by: OpenCode
pg_hba trusted connections from 127.0.0.1 and ::1, so anything entering
over loopback skipped both TLS and authentication. oc port-forward
arrives over loopback, which means the showcase-rbac schema-mode
discovery could reach the database in plaintext, contrary to the
"requires TLS for every network connection" contract the docs and the
RBAC values rely on.

Keep the unix socket trusted for the image's start hooks and let every
TCP client fall through to the hostssl scram-sha-256 rule. The readiness
probe stays healthy: pg_isready counts a password request as "server up".
Verified in podman with the unchanged start hook: plaintext loopback is
rejected, TLS + password connects, the socket still authenticates, and
check-container keeps returning 0.

Also correct the docs the previous commits touched: the external
PostgreSQL is deployed in Phase 4 with the RBAC instance, not during
cluster setup; the operator job's schema tests use the operator-managed
database, not the external one; and the cert secret comment no longer
claims the operator CRs mount it.

Assisted-by: OpenCode
@zdrapela
zdrapela force-pushed the rhdhbugs-4113-replace-crunchy branch from 1eb443f to d6b9712 Compare November 12, 2026 14:02
@zdrapela

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm-nightly
/test e2e-ocp-operator-nightly

@github-actions

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@sonarqubecloud

Copy link
Copy Markdown

@albarbaro

Copy link
Copy Markdown
Member

/agentic_review

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@zdrapela

Copy link
Copy Markdown
Member Author

@rhdh-qodo-merge We're removing Crunchy from the CI completely. Can you re-evaluate your review with this in mind?

@albarbaro

Copy link
Copy Markdown
Member

Went through the PR and the bot comments — nothing blocking imo. The secret reuse issue can't really happen (namespaces are fresh each run), migration doesn't matter for test data, and the other two are nits at best since it's all ephemeral.
The code looks good to me as well.
Will impact FIPS too but I will port these changes in my PR and eventually adjust accordingly.
Fine by me as long as the ocp jobs pass and don't catch any edge case.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Nov 12, 2026
@zdrapela

Copy link
Copy Markdown
Member Author

/cherry-pick release-2.1

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@zdrapela: once the present PR merges, I will cherry-pick it on top of release-2.1 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 6e6cd04 into redhat-developer:main Nov 12, 2026
19 of 21 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@zdrapela: #5820 failed to apply on top of branch "release-2.1":

Applying: chore(ci): replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet
Using index info to reconstruct a base tree...
A	.ci/pipelines/jobs/ocp-fips-helm.sh
M	.ci/pipelines/jobs/ocp-nightly.sh
M	.ci/pipelines/jobs/ocp-pull.sh
M	.ci/pipelines/utils.sh
M	docs/e2e-tests/CI-medic-guide.md
M	docs/e2e-tests/layer-migration-matrix.md
M	e2e-tests/playwright.config.ts
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): .ci/pipelines/jobs/ocp-fips-helm.sh deleted in HEAD and modified in chore(ci): replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet.  Version chore(ci): replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet of .ci/pipelines/jobs/ocp-fips-helm.sh left in tree.
Auto-merging .ci/pipelines/jobs/ocp-nightly.sh
Auto-merging .ci/pipelines/jobs/ocp-pull.sh
Auto-merging .ci/pipelines/utils.sh
Auto-merging docs/e2e-tests/CI-medic-guide.md
Auto-merging docs/e2e-tests/layer-migration-matrix.md
CONFLICT (content): Merge conflict in docs/e2e-tests/layer-migration-matrix.md
Auto-merging e2e-tests/playwright.config.ts
CONFLICT (content): Merge conflict in e2e-tests/playwright.config.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 chore(ci): replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet

Details

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants