Skip to content

chore: drop the legacy janus-idp and manual Postgres tests - #5827

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
zdrapela:chore/drop-janus-idp-name
Nov 12, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
zdrapela:chore/drop-janus-idp-name

Conversation

@zdrapela

@zdrapela zdrapela commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Cleanup split out of #5820.

  • Catalog: rename the demo janus-idp System to rhdh-examples and the janus-authors Group to rhdh-authors, and repoint all references
  • Catalog: point sonarqube.org/project-key at the live redhat-developer_rhdh SonarCloud project (the old janus-idp_backstage-showcase key no longer exists), and rename the showcase ArgoCD app and Kubernetes id/namespace to rhdh (no real app or namespace backs either the old or the new value)
  • Docs: replace stale links, the removed step-registry ref in the CI README, and the diagram label
  • Config: drop the unused @janus-idp Renovate rule and prettier import-order entries
  • CI: drop .ci/manual-tests/postgres, superseded by the automated PostgreSQL setup

Impact

The demo catalog is loaded from main by every branch's CI and by external setups (overlays E2E, rhdh-test-instance, rhdh-plugins scorecard), so PR checks cannot validate these changes.

  • main, release-1.10, release-2.1: no active test checks the renamed entities
  • release-1.9 (EOL): rbac.spec.ts checks the Janus-IDP Authors group and will fail; accepted
  • red-hat-developer-hub-software-templates: 15 template files set owner: janus-authors and system: janus-idp (13 of them loaded by templates.yaml), so those references point at missing entities until the templates are updated

Kept on purpose

Kept Removed when
GITHUB_APP_JANUS_TEST_* CI variables The Vault secret keys are renamed
janus-idp PostgreSQL user The automated PostgreSQL setup renames the database owner
janus-qe GitHub org references Never: it is the real org that the test fixtures live in
showcase.yaml component The separate PR that drops the showcase, after the overlays E2E suites get their own catalog fixtures

Follow-up

redhat-developer/red-hat-developer-hub-software-templates#35 repoints the templates that are imported into this catalog at the renamed Group and System. It should merge after this PR.

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Replace legacy janus-idp references in the demo catalog and CI docs

⚙️ Configuration changes 📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• Rename the demo catalog system to rhdh and repoint its APIs and resources.
• Refresh showcase integration annotations and replace stale documentation links and CI examples.
• Remove unused @janus-idp Renovate and import-order configuration.
Diagram

graph TD
  Location["Systems location"] --> System["RHDH system"] <-- APIs["Demo APIs"]
  Resources["Demo resources"] --> System
  Showcase["Showcase component"] --> Integrations["Integration identifiers"] <-- Repo["Repository component"]
Loading
High-Level Assessment

The scoped rename and reference updates fit a nonfunctional cleanup. Consolidating this demo System with the rhdh System already declared in the root catalog was considered, but would change catalog registration beyond the PR’s scope.

Files changed (21) +29 / -42

Documentation (5) +6 / -6
README.mdCorrect the operator documentation link +1/-1

Correct the operator documentation link

• Points the PostgreSQL manual-test guidance to the RHDH operator repository.

.ci/manual-tests/postgres/README.md

README.mdRefresh the nightly pipeline example +1/-1

Refresh the nightly pipeline example

• Replaces a removed step-registry reference with the current RHDH OCP Helm nightly step.

.ci/pipelines/README.md

update-backstage.yamlRemove the legacy scope from workflow guidance +1/-1

Remove the legacy scope from workflow guidance

• Omits 'janus-idp' from the example package-selection glob without changing workflow execution.

.github/workflows/update-backstage.yaml

customization.mdRefresh the support-button community example +2/-2

Refresh the support-button community example

• Replaces the defunct Janus community URL and title with an RHDH repository link and label.

docs/customization.md

github_diagram.svgCorrect the PR testing diagram’s member label +1/-1

Correct the PR testing diagram’s member label

• Changes the rendered approval-step label from a janus-idp member to an RHDH member; the depicted flow is unchanged.

docs/images/github_diagram.svg

Other (16) +23 / -36
renovate.jsonRemove the obsolete Janus CLI update group +0/-7

Remove the obsolete Janus CLI update group

• Drops the Renovate package rule for '@janus-idp/cli'.

.github/renovate.json

nexus-repo-manager-3.yamlAssign the Nexus API to the RHDH system +1/-1

Assign the Nexus API to the RHDH system

• Changes the API entity’s system reference from 'janus-idp' to 'rhdh'.

catalog-entities/apis/nexus-repo-manager-3.yaml

petstore.yamlAssign the Petstore API to the RHDH system +1/-1

Assign the Petstore API to the RHDH system

• Changes the API entity’s system reference from 'janus-idp' to 'rhdh'.

catalog-entities/apis/petstore.yaml

showcase.yamlRefresh showcase links and integration annotations +6/-6

Refresh showcase links and integration annotations

• Replaces the defunct blog link with releases and updates ArgoCD, Kubernetes, and SonarQube identifiers to their RHDH values.

catalog-entities/components/showcase.yaml

rbac-transitive-parent-ownership.yamlReplace legacy links in RBAC test entities +6/-6

Replace legacy links in RBAC test entities

• Changes three mock-site links from the Janus website to the RHDH GitHub repository.

catalog-entities/e2e-test-resources/rbac-transitive-parent-ownership.yaml

argocd.yamlAssign the ArgoCD resource to RHDH +1/-1

Assign the ArgoCD resource to RHDH

• Points the resource entity at the renamed 'rhdh' system.

catalog-entities/resources/argocd.yaml

github.yamlAssign the GitHub resource to RHDH +1/-1

Assign the GitHub resource to RHDH

• Points the resource entity at the renamed 'rhdh' system.

catalog-entities/resources/github.yaml

keycloak.yamlAssign the Keycloak resource to RHDH +1/-1

Assign the Keycloak resource to RHDH

• Points the resource entity at the renamed 'rhdh' system.

catalog-entities/resources/keycloak.yaml

obc.yamlAssign the OBC resource to RHDH +1/-1

Assign the OBC resource to RHDH

• Points the resource entity at the renamed 'rhdh' system.

catalog-entities/resources/obc.yaml

pgdb.yamlAssign the PostgreSQL resource to RHDH +1/-1

Assign the PostgreSQL resource to RHDH

• Points the resource entity at the renamed 'rhdh' system.

catalog-entities/resources/pgdb.yaml

systems.yamlRegister the renamed demo system file +1/-1

Register the renamed demo system file

• Updates the catalog location target to 'systems/rhdh.yaml'.

catalog-entities/systems.yaml

rhdh.yamlRename the demo System entity to RHDH +2/-2

Rename the demo System entity to RHDH

• Sets the System name to 'rhdh' and its title to Red Hat Developer Hub.

catalog-entities/systems/rhdh.yaml

catalog-info.yamlCorrect the repository SonarQube project key +1/-1

Correct the repository SonarQube project key

• Changes the root component’s SonarQube annotation to 'redhat-developer_rhdh'.

catalog-info.yaml

.prettierrc.jsRemove the backend Janus import-order group +0/-2

Remove the backend Janus import-order group

• Deletes the unused '@janus-idp' import-order pattern and separator.

packages/backend/.prettierrc.js

.prettierrc.jsRemove the dynamic-plugin Janus import-order group +0/-2

Remove the dynamic-plugin Janus import-order group

• Deletes the unused '@janus-idp' import-order pattern and separator.

plugins/dynamic-plugins-info-backend/.prettierrc.js

.prettierrc.jsRemove the licensed-users Janus import-order group +0/-2

Remove the licensed-users Janus import-order group

• Deletes the unused '@janus-idp' import-order pattern and separator.

plugins/licensed-users-info-backend/.prettierrc.js

@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Code Review by Qodo


Action required

1. Older catalog consumers lose their owner 🐞 Bug ⭐ New
Description
The group catalog replaces janus-authors with rhdh-authors, and the demo entities no longer
declare the legacy owner. Release-1.9 and external setups that load this catalog from main while
still using owner: janus-authors will have owner references with no matching group.
Code

catalog-entities/groups/rhdh-authors.yaml[R6-7]

+  name: rhdh-authors
+  title: RHDH Authors
Relevance

●●● Strong

Matches the PR's own stated intent: the description says the janus-authors group and owner must stay
until consumers migrate, yet the diff renames them. No rejection precedent found.

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The configured catalog imports all.yaml from main; that location imports groups.yaml, which
now targets only the replacement group. The new group has a different name, confirming that
consumers retaining the legacy owner cannot resolve it through this catalog. The PR description
explicitly identifies release-1.9, templates, and product-doc examples as consumers that still
require the old group and owner.

app-config.yaml[151-159]
catalog-entities/all.yaml[7-12]
catalog-entities/groups.yaml[3-9]
catalog-entities/groups/rhdh-authors.yaml[3-10]
catalog-entities/apis/petstore.yaml[17-20]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR removes the `janus-authors` group and its demo-entity owner references even though release-1.9 and external consumers still load this catalog from `main` and depend on that owner.

## Fix Focus Areas
- catalog-entities/groups.yaml[7-9]
- catalog-entities/groups/rhdh-authors.yaml[3-10]
- catalog-entities/systems/rhdh-examples.yaml[5-7]
- catalog-entities/apis/petstore.yaml[18-19]
- scripts/rhdh-openshift-setup/resources/rhdh-configmap.yaml[67-70]

## Recommended Fix
Keep a registered `janus-authors` group with its existing identity and retain `owner: janus-authors` on the demo entities until the release branches and external consumers no longer rely on it. The System can still be renamed to `rhdh-examples` independently.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.65%. Comparing base (063324e) to head (db73c3a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5827   +/-   ##
=======================================
  Coverage   78.65%   78.65%           
=======================================
  Files          67       67           
  Lines         726      726           
  Branches      100      100           
=======================================
  Hits          571      571           
  Misses        154      154           
  Partials        1        1           
Flag Coverage Δ
rhdh 75.70% <ø> (ø)
rhdh-e2e-frontend 71.23% <ø> (ø)
Components Coverage Δ
Backend plugins 100.00% <ø> (ø)
Backend app 78.94% <ø> (ø)
Frontend app 68.40% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063324e...db73c3a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zdrapela
zdrapela force-pushed the chore/drop-janus-idp-name branch from fd7c2a6 to 37ba4ca Compare November 12, 2026 09:37
@github-actions

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@zdrapela
zdrapela force-pushed the chore/drop-janus-idp-name branch from 37ba4ca to 3cb64d5 Compare November 12, 2026 10:13
@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

…ferences

- Rename the demo System entity to rhdh-examples and repoint its APIs and
  resources, so no entity points at a missing system and the name does not
  clash with the rhdh System in the root catalog-info.yaml
- Rename the janus-authors group to rhdh-authors and update its owner
  references
- Point the showcase catalog annotations and the SonarQube project keys at
  their current values
- Replace the removed step-registry ref in the CI README, the stale operator
  PR link, the dead community link and the diagram label
- Remove the dead renovate rule and prettier import-order entries for the
  @janus-idp scope, which no package depends on any more
- Drop .ci/manual-tests/postgres, superseded by the automated PostgreSQL CI

Assisted-by: OpenCode
@zdrapela
zdrapela force-pushed the chore/drop-janus-idp-name branch from 3cb64d5 to db73c3a Compare November 12, 2026 10:52
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@zdrapela zdrapela changed the title chore: drop the legacy janus-idp name from the demo catalog and CI references chore: drop the legacy janus-idp and manual Postgres tests Nov 12, 2026
@gustavolira

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Nov 12, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 13c6108 into redhat-developer:main Nov 12, 2026
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants