Repository navigation
[release-2.1] chore(ci): replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet - #5834
Conversation
|
/test e2e-ocp-operator-nightly |
|
/test e2e-ocp-v5-0-helm-nightly |
PR Summary by QodoReplace Crunchy PostgreSQL with a StatefulSet for OCP CI
AI Description
Diagram
High-Level Assessment
Files changed (25)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.1 #5834 +/- ##
===============================================
- Coverage 76.02% 69.38% -6.65%
===============================================
Files 64 57 -7
Lines 705 552 -153
Branches 100 83 -17
===============================================
- Hits 536 383 -153
Misses 168 168
Partials 1 1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Code Review by QodoView low (2) 1. Failed DB setup leaves the CI CA key on disk
|
|
@zdrapela: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5350445 to
23fd2a3
Compare
…tefulSet The Crunchy Postgres operator is not available in the OCP 5.0 certified-operators catalog (crunchy-postgres-operator is published for OCP 4.15-4.22 only), so every OCP job fails before the tests start. On top of that, Crunchy announced that the Developer Program images our PostgresCluster pulls will stop receiving updates on 2026-12-31. Deploy the external PostgreSQL used by showcase-rbac as a plain StatefulSet running registry.redhat.io/rhel9/postgresql-18 instead: - TLS server certificate generated by the CI script (CA + cert with SANs for the Service DNS names), served from the same postgress-external-db-cluster-cert secret the RBAC values mount. - The start hook restricts network connections to TLS and creates the rhdh SUPERUSER from postgress-external-db-pguser-rhdh. - The registry.redhat.io pull secret is created from the existing REGISTRY_REDHAT_IO_SERVICE_ACCOUNT_DOCKERCONFIGJSON CI secret. The Crunchy operator install, the PostgresCluster CRD waits and the OLM Subscription helpers (only used for Crunchy) are removed, together with the now empty cluster_setup_ocp_* hooks. Also rename the external DB TLS spec and update the CI docs accordingly. Adaptations for release-2.1: - Do not add the ocp-fips-helm.sh change: the job does not exist on this branch. - Keep the branch's Playwright projects and test ignores (auth-providers, no SHOWCASE_FIPS project) and only update the external DB spec name. - Keep the branch's layer-migration-matrix rows and only rename row 25. - The pr-triage content lives in .rulesync/commands here, so the edits are applied to that source and the generated copies are regenerated. Jira: https://redhat.atlassian.net/browse/RHDHBUGS-4113 Assisted-by: OpenCode (cherry picked from commit 6e6cd04)
23fd2a3 to
3013621
Compare
|
|
/lgtm |
7eb3a2e
into
redhat-developer:release-2.1



Manual backport of #5820 to release-2.1.
Replaces the Crunchy Postgres operator with a plain StatefulSet running
registry.redhat.io/rhel9/postgresql-18for the external PostgreSQL used byshowcase-rbac. The Crunchy operator is not published for OCP 5.0, so every OCP
job fails before the tests start.
Adaptations for release-2.1:
ocp-fips-helm.shchange, the job does not exist on this branch.spec was renamed.
.rulesync/commandshere, so the edits wereapplied there and the generated copies regenerated.
Validation
Results below are from commit
23fd2a381, same tree as HEAD: the commit wasre-created to re-run a flaky
markdown-link-check(transient GitHub 502 on anuntouched link).
ci/prow/e2e-ocp-helme2e-ocp-operator-nightlye2e-ocp-v5-0-helm-nightlyLocal: shellcheck (
-x -S warning),bash -n,oxfmt --check,oxlint,tsc,playwright test --list,rulesync generate --check.External PostgreSQL works on both OCP versions. The StatefulSet deployed in
both nightly runs (
✓ External PostgreSQL database configured successfully!,~30s), and
showcase-rbac- the only suite using the external DB - passed onOCP 5.0 (16 passed).
The two nightly failures are not caused by this change:
showcase-operator,showcase-operator-rbac) and then hit the 2h pod timeout inside theRDS/Azure runtime-db suite. The same job on release-2.1 timed out the same
way on [release-2.1] test(ci): run E2E against the 2.1 RC images (do not merge) #5685 and [release-2.1] fix(e2e): only retire runtime databases from runs that have ended #5690 before this branch existed.
Visited, sidebar Docs, Redis cache, catalog timestamp, auditor, build info
card) with 8 more flaky. The Quick Access failures are RHDHBUGS-4096, fixed
separately in [release-2.1] fix(e2e): mark Quick Access fixme on Kubernetes and seed the upgrade provider #5793. With retries, showcase took 53.7m instead of 1.7m, so
the runtime suite then hit the 2h timeout. The job has little headroom: the
passing run on main (chore(ci): replace Crunchy Postgres operator with RHEL PostgreSQL StatefulSet #5820) already used ~1h40m of the 2h limit.
Jira: https://redhat.atlassian.net/browse/RHDHBUGS-4113