Proton Pass: fix browser login, show its progress, add Check Again and Logout

[bst1n]

Description

Fixes browser logins that succeeded in the browser while the extension stayed logged out, and makes the Not Logged In screens say what's going on.

• Browser login no longer fails when the extension opens again right after it. pass-cli login saves the new session a few seconds after the browser step, and the extension ran other pass-cli commands meanwhile: reopening Search Items lists vaults. A command starting while the session is saved can find its data without its keyring key yet, and pass-cli then logs out "for security" (features/keyring.rs), deleting the session folder being written. The login then ends with Error opening temp session file: No such file or directory; in a failing login, another command had started in the same second. No pass-cli command runs during a login now: the views show the login screen until it's over. A login in the terminal never hits this, since nothing else runs then.
• The login runs on its own. pass-cli login ran inside the extension, which Raycast can stop once the browser comes to the front. It now runs detached, writing to a file in the extension's support folder, where its state is kept too. Both are removed once the login is over, since the output holds the login URL and its payload. Opening the extension again picks a running login up.
• The screens say what's happening.
  • Login with Browser keeps the screen as it is, with an "Opening the Login Page" toast, until the browser is in front.
  • Then "Log In in Your Browser", with Open Login Page Again, Check Again and Cancel Login, and "Finishing the Login" once pass-cli has the browser login.
  • Then "You're Logged In — Loading your items…" until Search Items, List Vaults or Get TOTP has something to show, instead of an empty list.
  • A failed login shows pass-cli's error, without the URL, payload or email addresses.
  • Get TOTP's Not Logged In screen is the same screen, so it can log in too.
• Check Again (⌘R) on Not Logged In screens picks up a session from a login done elsewhere.
• Logout in the Login command, after a confirmation, since the terminal shares the session. When ending the session on Proton's servers fails, the failure toast offers Force Logout.
• Open Terminal Login uses the extension's pass-cli, quoted for the shell, and brings Terminal to the front.

The tests run the detached login with the fake CLI:

• success, and a URL split across writes;
• failures, without exposing the payload;
• cancel, timeout, and a pass-cli stopped by a signal;
• an exit the extension missed, and the "finishing" step.

They also cover the guard that keeps other commands from running during a login, and the screens' sequence.

npm test passes (160 tests) and ray build succeeds.

Screencast

No new command: the Not Logged In screens gain the login's progress, and the Login command a Logout action.

Checklist

• I read the extension guidelines
• I read the documentation about publishing
• I ran npm run build and tested this distribution build in Raycast
• I checked that files in the assets folder are used by the extension itself
• I checked that assets used in the README are located outside the metadata folder if they were not generated with our metadata tool

🤖 Generated with Claude Code

---

Note

Medium Risk
Changes authentication orchestration and session timing (detached processes, blocking other CLI during login), but behavior is heavily tested and errors redact sensitive login output.

Overview
Fixes browser login races where reopening the extension right after authenticating could leave you logged out: while pass-cli saves the session, no other pass-cli calls run until login finishes.

Detached login replaces the in-process flow: pass-cli login runs on its own with state under the extension support folder, survives Raycast closing, and is picked up when you return. Not Logged In screens (Search Items, List Vaults, Get TOTP, Login) share a LoginScreen with step-by-step status (browser, finishing, loading items), Open Login Page Again, Cancel Login, and Check Again (⌘R) for sessions completed elsewhere.

The Login command adds Logout (with confirmation and Force Logout fallback) via new adapter logout support. Open Terminal Login uses the same bundled/configured pass-cli with safe shell/AppleScript quoting and activates Terminal. List Vaults shows vaults and item counts immediately and applies optional sharing metadata when it arrives.

^{Reviewed by Cursor Bugbot for commit 31d7242. Bugbot is set up for automated code reviews on this repo. Configure here.}

[raycastbot]

Thank you for your contribution! 🎉

🔔 @izyuumi @FeernandoOFF you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

📋 Quick checkout commands

BRANCH="proton-pass-login-fixes"
FORK_URL="https://github.com/bst1n/extensions.git"
EXTENSION_NAME="proton-pass"
REPO_NAME="extensions"

git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run dev

We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 15 business days.

[greptile-apps]

Confidence Score: 4/5

[Medium impact] Refactors browser login flow and adds logout capability.

The PR needs its changelog heading corrected before merging.

Findings

1.  Release date is set early ▶

Fix with agent prompt

### Issue 1
extensions/proton-pass/CHANGELOG.md:3
The new `CHANGELOG.md` heading uses a fixed date. The repository requires new changelog headings to keep `{PR_MERGE_DATE}` so the date can be filled in when the PR merges. Please restore the placeholder before merging.

```suggestion
## [Login Fixes] - {PR_MERGE_DATE}
```

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Proton Pass browser login now continues if Raycast closes, and other CLI commands wait until the session is saved so they do not interfere. The login screens show progress and recovery options, while the Login command adds Logout and List Vaults shows results before optional sharing details arrive.

• Browser login keeps running while Raycast is closed.
• Login screens show progress and help you finish or retry.
• The Login command can log out of Proton Pass.
• Terminal login uses the same pass-cli as the extension.
• List Vaults shows vaults before optional sharing details arrive.

_{Reviews (18) · Last reviewed commit: "Update CHANGELOG.md" · Reviewed by Greptile}

[cursor]

Stale Bugbot comment from a previous run.

[pernielsentikaer]

@bst1n can you resolve the merge conflicts 🙂

[cursor]

Stale Bugbot comment from a previous run.

[bst1n]

@pernielsentikaer the merge conflicts are resolved 🙂 Since then, this PR also fixes the browser login: it could succeed in the browser while the extension stayed logged out. The description explains the cause and the fix. It's ready for review.

[izyuumi]

Validated the current head 2edf907830ef2a3e68fe9612b57b289a9dcccb28, preserving the recent cache, browser-open cancellation, logout, and action-order fixes.

One additional regression remains: cancel a login whose process takes time to stop, complete a replacement login, then let the canceled process exit. Its late failure overwrites the shared exit-code file and Check Again reports failure for the successful replacement.

Implemented a small follow-up in bst1n/extensions#1, targeting this PR's branch: exit results are separated by process ID. The synthetic delayed-cancellation test fails before the fix and passes afterward. All 135 tests, distribution build/TypeScript, Raycast metadata validation, ESLint, Prettier, and diff checks pass. No real account or password CLI was used.

The follow-up is a draft for human review and integration; this PR remains the Raycast publication path.

[bst1n]

Thanks @izyuumi for testing it and for the fix 🙏 Good catch. I merged it into this branch.

[greptile-apps]

Comments Outside Diff

These findings could not be posted inline.

•  Review finding ▶

  Confidence Score: 5/5

  The latest changes appear safe to merge.

  What we checked:

  • Vault contents survive cache clearing: clearCache removes only cached items and vaults from local storage. It does not delete anything from Proton.

  Summary

  The PR lets browser login continue after Raycast closes, shows login progress, and adds Check Again and Logout.

  • Browser login keeps running while Raycast is closed.
  • Login screens show progress until the requested data loads.
  • The Login command can end the shared Proton Pass session.
  • Terminal login uses the extension’s CLI and brings Terminal forward.

[cursor]

Stale Bugbot comment from a previous run.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e687d61. Configure here.}

[izyuumi]

Validated both remaining outside-diff sharing findings on current head f0a21c6156f18eba97e28493a360f6c19f0ad189; both reproduce with synthetic services.

• List Vaults remains loading after its primary listing is ready while optional sharing is stalled. The fix shows/caches fetched vaults and counts first, then applies sharing using the existing latest-request and save-order guards.
• A sharing refresh starts member commands after login becomes active, either after a delayed role lookup or from the queued member work. The fix calls the existing guarded getAdapter() before each member command.

Implemented the narrow follow-up in bst1n/extensions#3, targeting this branch. The three regression cases fail before the fix and pass afterward; the older-response sharing/count regression also remains green. All 160 tests, distribution build/TypeScript, Raycast metadata validation, ESLint, Prettier, and diff checks pass. No real account, password CLI, or actual session disruption was used.

The changes preserve e687d611 and f0a21c61, including their login-check race coverage. The follow-up is a draft for human review/integration into this existing Raycast publication PR. Loading behavior follows the Raycast empty-state guidance.

[bst1n]

Thanks @izyuumi for testing it and for the fix 🙏 I merged it into this branch.

[pernielsentikaer]

Looks good to me, approved 🔥

[github-actions]

Published to the Raycast Store:
https://raycast.com/izyuumi/proton-pass

[raycastbot]

🎉 🎉 🎉

Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@bst1n).

Please link your GitHub account to your Raycast account to receive your credits and soon be able to exchange them for some swag.

[greptile-apps]

Release date is set early

The new CHANGELOG.md heading uses a fixed date. The repository requires new changelog headings to keep {PR_MERGE_DATE} so the date can be filled in when the PR merges. Please restore the placeholder before merging.

Suggested change

	## [Login Fixes] - 2026-10-10
	## [Login Fixes] - {PR_MERGE_DATE}

Rule Used: What: Changelog entries must use {PR_MERGE_DATE} placeholder in titles, be placed at the top of the file, and maintain descending version order. Why: Standardized placeholders and consistent ordering ensure changelogs are maintainable and merge da... (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: extensions/proton-pass/CHANGELOG.md
Line: 3

Comment:
**Release date is set early**

The new `CHANGELOG.md` heading uses a fixed date. The repository requires new changelog headings to keep `{PR_MERGE_DATE}` so the date can be filled in when the PR merges. Please restore the placeholder before merging.

```suggestion
## [Login Fixes] - {PR_MERGE_DATE}
```

**Rule Used:** What: Changelog entries must use `{PR_MERGE_DATE}` placeholder in titles, be placed at the top of the file, and maintain descending version order.  Why: Standardized placeholders and consistent ordering ensure changelogs are maintainable and merge da... ([source](https://app.greptile.com/raycast/-/custom-context?memory=c2214c11-df56-490a-b1c0-09a385df481a))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!