Skip to content

Proton Pass: show vaults before sharing and guard member refresh - #3

Merged
bst1n merged 1 commit into
bst1n:proton-pass-login-fixesfrom
izyuumi:fix/proton-pass-sharing-login-guard
Oct 10, 2026
Merged

bst1n merged 1 commit into
bst1n:proton-pass-login-fixesfrom
izyuumi:fix/proton-pass-sharing-login-guard

Conversation

@izyuumi

@izyuumi izyuumi commented Oct 10, 2026

Copy link
Copy Markdown

List Vaults currently waits for optional sharing/member lookups before showing already-fetched vaults and item counts. A sharing refresh also reuses an adapter across the role lookup and subsequent member commands, allowing new commands to launch after browser login has started.

Show and cache the primary listing first, then add sharing details when ready using the existing latest-request and save-order guards. Acquire the guarded adapter before each member command, including commands queued behind earlier member requests. Existing sharing failure fallback, complete-listing cache rules, and contributor login-check fixes remain intact.

This is a narrow follow-up against the current branch for raycast/extensions#31877, addressing the two remaining outside-diff findings. It is based on f0a21c6156f18eba97e28493a360f6c19f0ad189; it does not change the fixes in e687d611 or f0a21c61. Please integrate into the existing upstream PR for Raycast review/publication.

Validation:

  • Three targeted regression cases fail before the fix: loading remains active while sharing is stalled; nine member commands launch after login begins during role lookup; one queued command launches after login begins during member lookup.
  • The same cases pass after the fix; the existing older-response sharing/count regression also passes.
  • Full suite: 160/160 tests pass, including compile-only AppleScript verification and contributor login-check race tests.
  • Distribution build/TypeScript, Raycast metadata validation, ESLint, Prettier, and git diff --check pass.
  • Runtime regressions use real extension callbacks with synthetic CLI/login/storage services. No real password vault, installed password CLI, or session disruption was used.

Prepared with Codex; draft for human review.

@bst1n
bst1n merged commit 36be7b6 into bst1n:proton-pass-login-fixes Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants