Conversation
Nothing in Aurora's editor could insert them, pasted iframes became embeds the public view didn't render, and file drops needed an upload backend Aurora doesn't have. Aurora uses Plone blocks for media. The stock full preset keeps them. Part of #200.
* b6-table: Move the table drag handle fragment to @plone/quanta Releasing @plone/aurora 1.0.0-alpha.16 Release @plone/contents 1.0.0-alpha.3 Release @plone/publicui 1.0.0-alpha.8 Release @plone/cmsui 1.0.0-alpha.11 Release @plone/agave 1.0.0-alpha.8 Release @plone/theming 1.0.0-alpha.8 Release @plone/layout 1.0.0-alpha.13 Release @plone/blocks 1.0.0-alpha.17 Release @plone/plate 1.0.0-alpha.22 Release @plone/react-router 2.0.0-alpha.7 Release @plone/helpers 2.0.0-alpha.9 Release @plone/registry 4.0.0-alpha.4 Release @plone/quanta 1.0.0-alpha.1 Release @plone/components 5.0.0-alpha.5 Release @plone/client 2.0.0-alpha.8 Release @plone/icons 1.0.0-alpha.1 Release @plone/types 3.0.0-alpha.7 Split Quanta and icons out of @plone/components into @plone/quanta and @plone/icons (#212)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 7 of #200, changed to a removal: Aurora's presets no longer load Plate's media nodes, so there's nothing to convert. Same treatment as the native
imgnode in #201.Why
The plan was to move the video, audio, file, media embed and caption styles to
styles/content.css. But the media nodes can't be reached in Aurora:somersault-editorpreset offers them. The fixed toolbar that does is only in the stockfullpreset.<iframe>made amedia_embed. It showed in the editor, but the renderer kit has no component for it, so the public view didn't show the embed.PloneImageUploadPlugin, which makes Plone image blocks.Aurora uses Plone blocks for media (image, video…).
Changes
BlockEditorKitandBlockBaseEditorKit(used by thesomersault-*andblock-*presets) no longer includeMediaKit/BaseMediaKit. That removes the video, audio, file, media embed, upload placeholder and caption plugins.config.blocks.plateBlocksConfigloses itsvideo,audio,fileandmedia_embedentries.PloneImageUploadPlugin's comment says the media placeholder flow it takes over from only exists in other presets now.fullpreset (EditorKit/BaseEditorKit) still uses them, so they stay on Tailwind. That's fine, since plate outside Aurora doesn't need the content contract.Behavior changes
<iframe>media_embednode; shown in the editor, missing in the public view<video>/<audio>Nothing in Aurora could create video, audio or file nodes, so no stored content should have them. A
media_embedsaved from an earlier iframe paste would now render as an empty element in the editor too, as it already did publicly.Tests
paste.test.ts› "Pasting HTML with embedded media keeps only its text": pastes a heading, paragraphs, aniframe, avideoand anaudio, and checks that only the heading and paragraphs remain.Validation
CI=1 pnpm visual-test --retries=0: 24/24 pixel-identical.pnpm acceptance-test: 177 passed, including the new paste test.pnpm --filter @plone/plate test --run: 75 passed.pnpm --filter @plone/blocks test --run: 29 passed.check:ts(plate, blocks),eslintandprettier: clean.Part of #200.