Conversation
Callout, toggle, columns, table of contents and the rendered content root. The rendered content no longer has any Tailwind classes, so the contract test's PENDING list is gone. Part of #200.
This was referenced Oct 3, 2026
* b7-media: Move the table drag handle fragment to @plone/quanta Releasing @plone/aurora 1.0.0-alpha.16 Release @plone/contents 1.0.0-alpha.3 Release @plone/publicui 1.0.0-alpha.8 Release @plone/cmsui 1.0.0-alpha.11 Release @plone/agave 1.0.0-alpha.8 Release @plone/theming 1.0.0-alpha.8 Release @plone/layout 1.0.0-alpha.13 Release @plone/blocks 1.0.0-alpha.17 Release @plone/plate 1.0.0-alpha.22 Release @plone/react-router 2.0.0-alpha.7 Release @plone/helpers 2.0.0-alpha.9 Release @plone/registry 4.0.0-alpha.4 Release @plone/quanta 1.0.0-alpha.1 Release @plone/components 5.0.0-alpha.5 Release @plone/client 2.0.0-alpha.8 Release @plone/icons 1.0.0-alpha.1 Release @plone/types 3.0.0-alpha.7 Split Quanta and icons out of @plone/components into @plone/quanta and @plone/icons (#212)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 8 of #200: the callout, toggle, columns, table of contents and the rendered content root are styled by plain CSS instead of Tailwind utilities, with zero visual change. With this, the public view's content has no Tailwind classes left: the contract test's
PENDINGlist is gone.Changes
@plone/plate/styles/content.cssnow styles these nodes in both the public renderer and the editor..slate-callout > .block-inner-containermy-1 flex rounded-sm bg-muted p-4 pl-3block-callout__body,__icon,__content(new parts)flex w-full gap-2 rounded-md;size-6 text-[18px] select-nonewith an inline emojifont-family;w-full.slate-toggle > .block-inner-containerrelative pl-6block-toggle__icon(new part)absolute top-0 -left-0.5 size-6 cursor-pointer rounded-md p-px text-muted-foreground transition-colors select-none hover:bg-accent [&_svg]:size-4mb-2block-column_group__row(new part)flex size-full roundedblock-column_group__column(new part)group/column relative.slate-column, first/last via the wrapperh-full px-2 pt-2 group-first/column:pl-0 group-last/column:pr-0block-column__content(new part)relative h-full border border-transparent p-1.5.slate-toc > .block-inner-containermb-1 p-0block-toc__itemwithdata-depth(new)Button(ghost) merged with acvaof ~20 utilities,pl-[26px]/pl-[50px]per depthblock-toc__emptytext-sm text-gray-500block-toc__highlightpointer-events-none absolute inset-0 z-1 bg-brand/[.13].slate-editor(Plate's own class)relative w-full cursor-text overflow-hidden break-words whitespace-pre-wrap select-text rounded-md,[&_[data-slate-node="element"]:not(…)]:mx-auto,[&_strong]:font-bold, plus focus and placeholder utilitiesPlateRenderernow renders Plate'sPlateViewdirectly instead ofEditorView, so the public root no longer gets the editor'seditorVariants.content.css, so they still win over the block rules, as they did as utilities. Themx-autoon element nodes overrode the title's margins, for instance.editorVariants.variant="none", whichPlateRendereralways overrode anyway; it's removed.<button type="button">s in both the renderer and the editor, instead of the chromeButton. A theme's TOC rules now apply in the editor too.inline-flex/gap/centering, overridden byblock; thesvganddisabled/aria-invalidvariants; anddark:.type="button"is new: these buttons no longer submit a surrounding form.--block-callout-icon-font-family.PopoverAnchorwraps the inner container. So the column group's spacing rule matches the inner container that holds the row (:has(> .block-column_group__row)), not a direct child. The first visual run caught this as an 8px shift in the editor.Tests
New:
plate/acceptance/tests/structural-content-css.test.tscompares the computed values these rules set in the public view, under Agave's preflight, with no reset, and under@plone/theming's simple reset. It covers:strong, and the root's inline margins on the title;Sizes that follow the text aren't compared, since removing the reset also removes the theme's font.
Ratchet finished:
PENDINGis removed. The contract test now expects no classes outside the contract in the public view.Docs:
packages/plate/AGENTS.mdno longer mentions thePENDINGlist.Validation
CI=1 pnpm visual-test --retries=0: 24/24 pixel-identical, including the native-blocks screenshots in the public view (desktop and mobile) and the editor.pnpm acceptance-test: 178 passed.pnpm --filter @plone/plate test --run: 75 passed.check:ts,eslint,stylelintandprettier: clean.Part of #200.