Conversation
A how-to guide with every block's parts and tokens, fixed content styles examples, and BlockInnerContainer uses clsx instead of the Tailwind-aware cn. Closes the conversion phases of #200.
* b10-plone-blocks: Move the table drag handle fragment to @plone/quanta Releasing @plone/aurora 1.0.0-alpha.16 Release @plone/contents 1.0.0-alpha.3 Release @plone/publicui 1.0.0-alpha.8 Release @plone/cmsui 1.0.0-alpha.11 Release @plone/agave 1.0.0-alpha.8 Release @plone/theming 1.0.0-alpha.8 Release @plone/layout 1.0.0-alpha.13 Release @plone/blocks 1.0.0-alpha.17 Release @plone/plate 1.0.0-alpha.22 Release @plone/react-router 2.0.0-alpha.7 Release @plone/helpers 2.0.0-alpha.9 Release @plone/registry 4.0.0-alpha.4 Release @plone/quanta 1.0.0-alpha.1 Release @plone/components 5.0.0-alpha.5 Release @plone/client 2.0.0-alpha.8 Release @plone/icons 1.0.0-alpha.1 Release @plone/types 3.0.0-alpha.7 Split Quanta and icons out of @plone/components into @plone/quanta and @plone/icons (#212)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 11 of #200, the last one: a theming guide for blocks, fixed docs examples, and the last Tailwind helper left in content code. No visual change.
Changes
New how-to: "Style blocks in a theme"
docs/how-to-guides/style-blocks-in-a-theme.md, linked from the how-to index, covers:Where block styles go: an add-on's
styles/content.css, loaded in both the Public UI and the editor. It links to the authoring rules in the styles loader guide (Content CSS architecture: cascade layers, reset placement, and a shared block-styles entry point #199).Two ways to change a block: set a token on
.content-area(preferred), or override a rule, since the framework rules have zero specificity.The hooks: block root, Plate node, inner part and variant.
Every block's parts and variants:
Every token, with its default:
--block-bottom-spacing, the container widths,--block-float-max-size);--block-*-background,--block-separator-color,--block-table-border-color, …);--code-token-*syntax colors and thehljs-*classes each one covers;It also names the internal properties a theme shouldn't set.
Examples: dark code blocks via
prefers-color-scheme, and a callout override.Resets: a theme's own reset belongs in the
baselayer.Docs fixes
add-on-styles-loader.md: the override example used a.block-image__captionpart that doesn't exist. It now uses the callout's real rule and token, and links to the new guide.block-anatomy.md:block-video, but since Content CSS Phase 7: remove the Plate media nodes from Aurora's presets #215 Aurora has no native video node; it's now generic.__link,__item,__image).Cleanup
BlockInnerContainermerges its classes withclsx, notcn:cnistwMerge. The content code's other Tailwind helpers (cn,cva) went away in Phases 2–8.EditorStatic'scva. Only the stockfullpreset's export and AI chat use it, which makes it chrome.Validation
make docs-html: builds. The 6 warnings are all pre-existing: news fragments outside a toctree, and a/storybooklink.Ploneterm pattern, flagged on every page.CI=1 pnpm visual-test --retries=0: 26/26 pixel-identical.pnpm acceptance-test: 182 passed.pnpm --filter @plone/plate test --run: 75 passed.check:tsandeslint: clean.With this, the phases of #200 are complete. What's left is the review and merge order of the stack, and the VRT baseline updates noted in #217 and #218.
Part of #200.