Skip to content

charts: bump advanced-statefulset to v0.7.1 - #7028

Merged
ti-chi-bot[bot] merged 1 commit into
release-1.xfrom
agent/bump-asts-v0.7.1-release-1.x
Aug 11, 2026
Merged

charts: bump advanced-statefulset to v0.7.1#7028
ti-chi-bot[bot] merged 1 commit into
release-1.xfrom
agent/bump-asts-v0.7.1-release-1.x

Conversation

@fgksgf

@fgksgf fgksgf commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Update the release-1.x chart default AdvancedStatefulSet controller image from v0.7.0 to v0.7.1.
  • Pick up the v0.7 maintenance fix that makes ControllerRevision adoption retries idempotent.
  • Backport this dependency update to release-1.6 after the source PR merges.

Why

AdvancedStatefulSet v0.7.0 can retry a partially completed native StatefulSet migration with a mix of orphaned and already-owned ControllerRevisions. The retry may fail with attempt to adopt revision owned by ... before Pod lifecycle reconciliation, preventing a missing Pod from being recreated.

The fix was backported in pingcap/advanced-statefulset#133 and released as v0.7.1.

How

  • Change only advancedStatefulset.image in the Helm chart defaults.
  • Keep the existing v0.7 API, CRD, command-line flags, and dependencies unchanged.
  • Leave installations with an explicit advancedStatefulset.image override unaffected.

Testing

  • helm lint charts/tidb-operator --set advancedStatefulset.create=true
  • helm template tidb-operator charts/tidb-operator --namespace tidb-admin --set advancedStatefulset.create=true --show-only templates/advanced-statefulset-deployment.yaml rendered pingcap/advanced-statefulset:v0.7.1
  • git diff --check origin/release-1.x..HEAD
  • docker buildx imagetools inspect docker.io/pingcap/advanced-statefulset:v0.7.1 verified linux/amd64 and linux/arm64 manifests

Risks and Reviewer Focus

  • When advancedStatefulset.create=true and no image override is set, applying the updated chart rolls the ASTS controller to v0.7.1.
  • No TiDB Operator binary, ASTS CRD, or workload specification changes are included.
  • Cluster-backed E2E was not run for this chart-only change; the source fix passed a local kind migration E2E, and the release-0.7 backport carries the same regression coverage.

Repository Checklist

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects: updates the default ASTS controller image when ASTS chart deployment is enabled

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Upgrade the default AdvancedStatefulSet controller image to v0.7.1 to fix ControllerRevision adoption retries that can block Pod reconciliation after StatefulSet migration.

@ti-chi-bot
ti-chi-bot Bot requested a review from howardlau1999 August 11, 2026 04:23
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e93de1fd-0357-47b4-bea3-52c8a3e5aeca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fgksgf

fgksgf commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.6

@ti-chi-bot

Copy link
Copy Markdown
Member

@fgksgf: once the present PR merges, I will cherry-pick it on top of release-1.6 in the new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Aug 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-08-11 05:49:40.096221685 +0000 UTC m=+3111966.132316741: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 11, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 0045b12 into release-1.x Aug 11, 2026
13 of 16 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the agent/bump-asts-v0.7.1-release-1.x branch August 11, 2026 05:53
@ti-chi-bot

Copy link
Copy Markdown
Member

@fgksgf: new pull request created to branch release-1.6: #7029.

Details

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants