Skip to content

charts: bump advanced-statefulset to v0.7.1 (#7028) - #7029

Open
ti-chi-bot wants to merge 1 commit into
pingcap:release-1.6from
ti-chi-bot:cherry-pick-7028-to-release-1.6
Open

charts: bump advanced-statefulset to v0.7.1 (#7028)#7029
ti-chi-bot wants to merge 1 commit into
pingcap:release-1.6from
ti-chi-bot:cherry-pick-7028-to-release-1.6

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #7028

Summary

  • Update the release-1.x chart default AdvancedStatefulSet controller image from v0.7.0 to v0.7.1.
  • Pick up the v0.7 maintenance fix that makes ControllerRevision adoption retries idempotent.
  • Backport this dependency update to release-1.6 after the source PR merges.

Why

AdvancedStatefulSet v0.7.0 can retry a partially completed native StatefulSet migration with a mix of orphaned and already-owned ControllerRevisions. The retry may fail with attempt to adopt revision owned by ... before Pod lifecycle reconciliation, preventing a missing Pod from being recreated.

The fix was backported in pingcap/advanced-statefulset#133 and released as v0.7.1.

How

  • Change only advancedStatefulset.image in the Helm chart defaults.
  • Keep the existing v0.7 API, CRD, command-line flags, and dependencies unchanged.
  • Leave installations with an explicit advancedStatefulset.image override unaffected.

Testing

  • helm lint charts/tidb-operator --set advancedStatefulset.create=true
  • helm template tidb-operator charts/tidb-operator --namespace tidb-admin --set advancedStatefulset.create=true --show-only templates/advanced-statefulset-deployment.yaml rendered pingcap/advanced-statefulset:v0.7.1
  • git diff --check origin/release-1.x..HEAD
  • docker buildx imagetools inspect docker.io/pingcap/advanced-statefulset:v0.7.1 verified linux/amd64 and linux/arm64 manifests

Risks and Reviewer Focus

  • When advancedStatefulset.create=true and no image override is set, applying the updated chart rolls the ASTS controller to v0.7.1.
  • No TiDB Operator binary, ASTS CRD, or workload specification changes are included.
  • Cluster-backed E2E was not run for this chart-only change; the source fix passed a local kind migration E2E, and the release-0.7 backport carries the same regression coverage.

Repository Checklist

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects: updates the default ASTS controller image when ASTS chart deployment is enabled

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Upgrade the default AdvancedStatefulSet controller image to v0.7.1 to fix ControllerRevision adoption retries that can block Pod reconciliation after StatefulSet migration.

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cofyc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 39f66571-7424-4e0c-bb02-c9e3c71dee9a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-kind-tidbcluster 53b415f link false /test pull-e2e-kind-tidbcluster

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants