[release-1.6] Bump advanced-statefulset to v0.7.1 - #7027
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
release-1.6chart default AdvancedStatefulSet controller image from v0.7.0 to v0.7.1.Why
AdvancedStatefulSet v0.7.0 can retry a partially completed native StatefulSet migration with a mix of orphaned and already-owned ControllerRevisions. The retry may fail with
attempt to adopt revision owned by ...before Pod lifecycle reconciliation, preventing a missing Pod from being recreated.The fix was backported in pingcap/advanced-statefulset#133 and released as v0.7.1. A production recovery confirmed that upgrading the controller to v0.7.1 allowed the affected Pod to be recreated and the interrupted rolling upgrade to complete.
How
advancedStatefulset.imagein the Helm chart defaults.advancedStatefulset.imageoverride remain unaffected.Testing
helm lint charts/tidb-operator --set advancedStatefulset.create=truehelm template tidb-operator charts/tidb-operator --namespace tidb-admin --set advancedStatefulset.create=true --show-only templates/advanced-statefulset-deployment.yamlrenderedpingcap/advanced-statefulset:v0.7.1git diff --check origin/release-1.6..HEADdocker buildx imagetools inspect docker.io/pingcap/advanced-statefulset:v0.7.1verified linux/amd64 and linux/arm64 manifestsRisks and Reviewer Focus
advancedStatefulset.create=trueand no image override is set, applying the updated chart rolls the ASTS controller to v0.7.1.Repository Checklist
Code changes
Tests
Side effects
Related changes
Release Notes