Skip to content

[release-1.6] Bump advanced-statefulset to v0.7.1 - #7027

Closed
fgksgf wants to merge 1 commit into
release-1.6from
agent/bump-asts-v0.7.1-release-1.6
Closed

[release-1.6] Bump advanced-statefulset to v0.7.1#7027
fgksgf wants to merge 1 commit into
release-1.6from
agent/bump-asts-v0.7.1-release-1.6

Conversation

@fgksgf

@fgksgf fgksgf commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Update the TiDB Operator release-1.6 chart default AdvancedStatefulSet controller image from v0.7.0 to v0.7.1.
  • Pick up the v0.7 maintenance fix that makes ControllerRevision adoption retries idempotent.

Why

AdvancedStatefulSet v0.7.0 can retry a partially completed native StatefulSet migration with a mix of orphaned and already-owned ControllerRevisions. The retry may fail with attempt to adopt revision owned by ... before Pod lifecycle reconciliation, preventing a missing Pod from being recreated.

The fix was backported in pingcap/advanced-statefulset#133 and released as v0.7.1. A production recovery confirmed that upgrading the controller to v0.7.1 allowed the affected Pod to be recreated and the interrupted rolling upgrade to complete.

How

  • Change only advancedStatefulset.image in the Helm chart defaults.
  • Keep the existing v0.7 API, CRD, command-line flags, and dependencies unchanged.
  • Existing installations with an explicit advancedStatefulset.image override remain unaffected.

Testing

  • helm lint charts/tidb-operator --set advancedStatefulset.create=true
  • helm template tidb-operator charts/tidb-operator --namespace tidb-admin --set advancedStatefulset.create=true --show-only templates/advanced-statefulset-deployment.yaml rendered pingcap/advanced-statefulset:v0.7.1
  • git diff --check origin/release-1.6..HEAD
  • docker buildx imagetools inspect docker.io/pingcap/advanced-statefulset:v0.7.1 verified linux/amd64 and linux/arm64 manifests

Risks and Reviewer Focus

  • When advancedStatefulset.create=true and no image override is set, applying the updated chart rolls the ASTS controller to v0.7.1.
  • No TiDB Operator binary, ASTS CRD, or workload specification changes are included.
  • Cluster-backed E2E was not run for this chart-only change; the source fix passed a local kind migration E2E, and the release-0.7 backport carries the same regression coverage.

Repository Checklist

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects: updates the default ASTS controller image when ASTS chart deployment is enabled

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Upgrade the default AdvancedStatefulSet controller image to v0.7.1 to fix ControllerRevision adoption retries that can block Pod reconciliation after StatefulSet migration.

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ehco1996 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9abd66ce-1aaa-47bb-a81a-4269ab393941

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/XS label Aug 11, 2026
@fgksgf

fgksgf commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

Closing this direct release-1.6 PR to follow the repository source-first flow. Replacement source PR: #7028. After #7028 merges, /cherry-pick release-1.6 will create the linked backport PR.

@fgksgf fgksgf closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant