Repository navigation
Update DMTCP for its make uninstall fix - #561
Merged
Merged
Conversation
Move the dmtcp submodule from 157726db to 5163a3d1, on DMTCP's main branch. The new commits change only DMTCP's build files and its CI: - dmtcp/dmtcp#1314 regenerates configure with automake 1.17. DMTCP's Makefile.in files came from automake 1.17, but its configure came from automake 1.16, which does not set am__xargs_n. So DMTCP's 'make uninstall' failed with '@am__xargs_n@: command not found'. - dmtcp/dmtcp#1313 makes DMTCP's 'make uninstall' remove the files that it left behind, and fixes 'make install' with --enable-m32. Tested: the files that make builds in bin/ and lib/ are the same as before, apart from debug info and the build ID. 'make install' installs the same files, and DMTCP's 'make uninstall' now removes all of them.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 5, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the dmtcp submodule from 157726db to 5163a3d1 (DMTCP's main). The new DMTCP commits change only DMTCP's build files and its CI:
configurewith automake 1.17. Before, DMTCP'smake uninstallfailed with@am__xargs_n@: command not found.make uninstallremove the files that it left behind, and fixesmake installwith--enable-m32.On main, MANA's
make uninstallstill fails after DMTCP's part, becausempi-proxy-splithas nouninstallrule. #559 adds MANA's part.Checks:
makebuilds inbin/andlib/are the same, apart from debug info and the build ID.make installinstalls the same 29 files. DMTCP'smake uninstallleft 19 of them before; now it removes all of them.bin/andlib/are the same, andmake installinstalls the same 38 files.autotest.py --mana-rooton the prefix passes 3 of 3, with the source tree'sbin/andlib/moved away.make uninstallexits 0 and removes every installed file.