Repository navigation
Support 24 more published ImageNet classifiers through YAML inheritance - #31
Conversation
Preserve existing alias and update semantics across 334 configs and 595 variants. Add ordered resolution and CPU preprocessing regression tests without changing shipped model definitions. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Verify exact runtime board paths using metadata only, preserve local-only restrictions and distinguish live commits from approval provenance. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Keep existing marker-free configs unchanged and preserve Hub MXQ loading. Skip only marked ONNX in metadata verification, with positive and negative CPU guard tests. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1dbd45926
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Exclude configuration-only marker from MXQ runtime kwargs, guard compilation downloads and cover local/unmarked positive paths. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@codex review Review guide for exact head
|
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🛡️ Codex Security Review · Automatically triggered
Here are some automated security review suggestions for this pull request.
Reviewed commit: 31ddef1a10
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Use official timm defaults and no-network pending status for new sibling configurations only. Preserve all pre-existing YAML bytes and allow trusted local artifacts without inventing HF publication metadata. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@codex review Exact head |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Retain pending and ONNX-only safety behavior plus new configured-board precedence from main. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@codex review Exact head Full offline CPU 1489 passed,19 deselected. Includes all595 legacy variant identities. No version bump, release, tag or publish. Review exact head before squash merge. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review One-time approval re-request for unchanged exact head |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
models/bases/imagenet_classifier.yamlwith only model-specific preprocessing/artifact overrides. Register task and top-level exports through the existing class factory.ViT_Large_Patch14_CLIP_224uses TF, not OpenAI normalization.file_cfg.onnx_local_artifact_only: trueon this new base: keep MXQ Hub loading, require trusted local ONNX, and skip only that framework in the metadata verifier. Positive/negative guard tests cover local ONNX, blocked remote ONNX, active MXQ, and unchanged marker-free downloads.Stack
Base: #29 (
feat/hf-artifact-verification), itself on #28. The framework-specific verifier skip is introduced only here, after #29's metadata helper; this avoids editing the reviewed #29 head. No merges performed.Source and revision policy
Recorded inputs and distribution contracts: mblt-model-ops commit
6fdbf471a3bd6ec22035a42c8730fe88a68881e4,models/image_classification/<Model>/_source/predict_float.input.jsonanddistribution.yaml. New configs retain the establishedrevision: mainconvention; historical approved artifact revisions are not recorded. The observed commits below are live audit diagnostics, not invented historical approval pins.CPU validation
rtol=0, atol=5e-7. This compares preprocessing only, not inference weights or end-to-end accuracy. The bundle-local PIL import is shimmed; reference resize/crop/normalization operations run unchanged, parameterized by each exact distribution contract.Actual HF file availability (all 24 queried)
f04bbb0543b2becd767840558c7e9aa715121eb481e7193f3b490051407ee6a3faa5143d86c6dd3a21804ae0b9d93c4251e11e5c89bd683b14024583c93cbc15d316aa581fedf12dd4edbc6e2d628c9564ca04e2fd4cc81fabc1ae68d97e13d550b184605f48f8e459e572a8904c0a22d29f4c22dcd69b05e1a5f1af2b2db4ae2ab1f9882e26326401b5613741489de292c0d8a68b01d5f9dddb61c276e0eb342fc5717c3023d069db3a120a032d6b40e3bdb8377326cc3412ab1430c56782f638d50d87eb644bf441b70f914862e372a42980a19134379098ae898b7638ff9bbf3400ffc952ef4c3a2efae155b84e1a872060d4caa777839b4fb2a4935caeb574fc908972a0af1bb9287552f6c7c4938f5a7e41e48ffb46883b832554b3239dd87986f129c7150b5c822355ffd2d6accffa8445f71b1e7ebcf591b4c1705d3f62cf9020cc06765f3a0601bdc394c2b4552eacd42877d86c5f8b6cb81d53460775d8561d0ba179550e6e9b5f2c1375058f1995e088d20280bc2af1a4238b90395b01eb187b9727336bd131204b59511007555ac72b4880c1aa8ba6266dcc3f2e8616d64f0e7fa05e8fee1a6272f356c70eb62a5a1fde82981e5f404ce0cb49ef4e4b9e85f8b1644e10884955a889bd57d5268dfb2b34204f3e93310687d424e3No repository in this table contained any
.onnxfile under any path. ONNX requires a trusted localmodel_path/onnx_path; the API and derived filename convention remain intact.Review guide
Head:
b1dbd45926940fca4edec730ca07efe245d2bf8e. Check family inheritance order, the non-obvious TF normalization exception, all exports, board-specific canonical filenames, framework-local marker guarding only new models, and all-595 legacy identity coverage. Do not interpret observed HF tips as historical approval provenance.🤖 Generated with Claude Code
Follow-up family-sibling commit
artifact_status: pending_hf_family_siblingskips metadata network access and blocks automatic runtime/compile downloads; trusted local paths remain valid. Existing sibling YAML bytes stay unchanged.