Repository navigation
Add person ReID embedding utilities and source-exact retrieval protocols - #30
Conversation
Preserve existing alias and update semantics across 334 configs and 595 variants. Add ordered resolution and CPU preprocessing regression tests without changing shipped model definitions. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…tocol scoring Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1289eb095
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@codex review Review exact head Fixed all three first-round threads: engine postprocess now retains validated matrices in Results.embeddings/output; generic EmbeddingPost is exported from mblt_vision.person_reid; dataset_ready supports Market-1501/DukeMTMC-reID/Occluded-Duke with source counts, names/cameras and full image decoding. Threads 4464940725, 4464940730, 4464940742 have replies and are resolved. Please check the engine Results contract and invalid result inputs, the public import, and valid/incomplete/corrupt readiness fixtures. Offline CPU: 1409 passed, 16 deselected; existing protocol/preprocessing parity and 595 variant identity tests remain green. No OBB/DOTA, CLI routing or version changes. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@codex review Exact head Full offline CPU after integration: 1413 passed, 16 deselected. Existing all-595 variant identity proof remains green. Please review this exact integration head; dependent PRs #31/#32 have been retargeted to main before any parent branch deletion. Squash merge will occur only after exact-head agent approval. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@codex review Exact head Full offline CPU 1425 passed,19 deselected. Includes all595 legacy variant identities. No version bump, release, tag or publish. Review exact head before squash merge. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3414b781f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Omit uncomputed rank metrics for truncated CMC, reject negative IDs below junk marker and reject symlinked roots or split ancestors. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@codex review Exact head |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Stacked on #28 (
281b8683f42342e6fdd57764b76ba1f39ded2356), not independently mergeable before that base. Stage c1 only; published model/HF YAMLs are deferred to stage d2.EmbeddingPostand dataset-boundPersonReIDPost, selected by configuration, plus opt-in processing family bases.mblt_vision.person_reid; CLI routing and benchmark support remain unchanged.Validation (CPU only)
git diff --checkpass.Provenance / boundaries
Exact read-only ops source:
ec537764e36ca10da963fcb7afab157ea60ca022,datasets/_shared/reid.py, each dataset private loader/evaluator/config andmodels/person_reid/_shared/preprocess.py. Test references are pinned offline snapshots. Dataset YAML source/evaluation blocks include exact paths and revision.No inference/accuracy claim, HF mutation, redistribution of sample data, GPU/NPU use or --execute. No OBB/DOTA, CLI routing or version changes. Camera-aware multi-input models are not claimed by this utility-only stage.
🤖 Generated with Claude Code