Skip to content

Add twelve published CLIP-ReID model configurations - #33

Merged
parkjinman98 merged 24 commits into
mainfrom
feat/published-reid-d2
Nov 5, 2026
Merged

parkjinman98 merged 24 commits into
mainfrom
feat/published-reid-d2

Conversation

@parkjinman98

@parkjinman98 parkjinman98 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Stage d2, now based directly on main. Dependencies #31 and #32 have landed. Main-sync merge 45fac2076191f3abb94228bdd83e64bff6d49dff integrates #32's squash 7c8ce909974f35fcd23e4c278976a62c74190351 without force-pushing. Face-verification conflicts use main's versions; the ReID-only binary diff is byte-identical to the previously reviewed #33 scope (87ff416..c765f8a). The final diff contains only twelve model YAMLs, the person_reid base/exports, registry metadata tests, and related documentation (20 files).

  • Add twelve CLIP-ReID RN50 / ViT-B-16 baseline / fine-tuned YAMLs, each tied to Market-1501, DukeMTMC-reID or Occluded-Duke.
  • Inherit shared RN50/ViT processing bases; add task exports, lazy top-level exports and model discovery.
  • Read-only live HF metadata confirms exact canonical aries-rb MXQ paths for all twelve; none publishes ONNX. Set onnx_local_artifact_only while keeping automatic MXQ loading.
  • Preserve revision main under project policy and explicitly record approved HF revision as not recorded. Source blocks record the exact inspected ops commit/distribution/recorded preprocessing paths; live HF SHA is diagnostic, not an approval pin.
  • ArcFace/CosFace eight-model packet is approved but HF publish pending: inventory-only, no YAML or guessed Hub identity.

Source and parity

Ops ec537764e36ca10da963fcb7afab157ea60ca022: every model distribution.yaml and _source/predict_float.input.json were directly compared. All use single-input image-embedding.v1. RN50: 3072D, 256x128, torch stats. ViT: 1280D, 256x128, 0.5 stats. Existing HWC/no-op SetOrder semantics are preserved through PIL resize then explicit float32 normalization.

Each of 12 concrete pipelines has synthetic RGB byte parity (atol=0). Postprocessing validates dimensions and unit norms; no accuracy claims or inference run.

Validation

CPU-only full offline suite on exact head 45fac2076191f3abb94228bdd83e64bff6d49dff: 1695 passed, 15 skipped, 19 deselected. Targeted ReID, face-verification, manifest and inheritance tests: 676 passed. Repository-pinned Ruff v0.6.9 lint passes across all files; both pre-commit hooks pass on all 20 PR-changed files; git diff --check passes. Previous wheel validation confirmed all twelve YAMLs and no development assets/tests.

The main baseline has formatting drift in nine unrelated files; those files are intentionally unchanged by #33. A standalone newer system Ruff also picks up external parent configuration, so the passing lint gate is the repository's pinned pre-commit Ruff hook.

No weights/dataset downloads, HF writes, GPU/NPU runs, --execute, OBB/DOTA, CLI routing, version changes, releases or tags. revision: main remains unchanged. Awaiting fresh exact-head Codex review before squash merge.

🤖 Generated with Claude Code

parkjinman98 and others added 13 commits November 4, 2026 16:22
Preserve existing alias and update semantics across 334 configs and 595 variants. Add ordered resolution and CPU preprocessing regression tests without changing shipped model definitions.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Verify exact runtime board paths using metadata only, preserve local-only restrictions and distinguish live commits from approval provenance.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…tocol scoring

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Keep existing marker-free configs unchanged and preserve Hub MXQ loading. Skip only marked ONNX in metadata verification, with positive and negative CPU guard tests.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Exclude configuration-only marker from MXQ runtime kwargs, guard compilation downloads and cover local/unmarked positive paths.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Use official timm defaults and no-network pending status for new sibling configurations only. Preserve all pre-existing YAML bytes and allow trusted local artifacts without inventing HF publication metadata.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…figs

Merge PR31 aaf0c14 into the approved PR32 lineage; guide and README additions auto-merge preserving both utility and artifact policies.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T01:36:08.826390Z 45fac20 Manual request
🔒 Security Review ✅ Completed 2026-11-05T01:37:47.621939Z 45fac20 Manual request

Security findings

Advisory findings (1)

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bc2db8f41

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mblt_vision/README.md Resolved
Comment thread mblt_vision/__init__.py Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️ Codex Security Review · Automatically triggered

Here are some automated security review suggestions for this pull request.

Reviewed commit: 6bc2db8f41

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

parkjinman98 and others added 3 commits November 4, 2026 18:05
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Retain pending and ONNX-only safety behavior plus new configured-board precedence from main.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Preserve current main retrieval validation fixes and apply only original face verification changes.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
parkjinman98 and others added 4 commits November 4, 2026 18:33
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Retain upstream Hub, retrieval rank validation, negative identity and symlink protections; preserve classifier markers, face utility dispatch and wrapper-only published exports.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
… precedence

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@parkjinman98

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact integrated head 32df9809dd60f3e798546042893bae7f74c6ac5b. Merged main c7cf545 (#30 squash with retrieval max-rank, negative-ID and symlink fixes), face dependency #32 097c810 (root/manifest/image symlink protections) and classifier dependency #31 b37c5bd (marker/runtime/compile guards plus verifier board precedence). No force-push or duplicated guards. Conflict resolutions preserve upstream corrected reid/Hub implementations, latest face readiness and tests, d1 markers and ReID12 wrapper-only exports.

Fixed/resolved code threads 4465211325 and 4465211336: no unsupported compile promise, explicit unsupported regression, and only model wrappers become top-level lazy exports. Security thread4465226206 addressed under project policy: this utility intentionally tracks main; strict revision/digest pinning is not required; no live tip was invented as historical approval provenance.

Please inspect integration regressions, model-only exports, maintained artifact guards and source preprocessing. Full CPU suite: 1601 passed/19 deselected including 595 baseline identity, d1 marker/classifier/runtime/compile tests, c1/c2 symlink and protocol tests, ReID12 byte parity(atol0). Depends on #31/#32; no PR merge performed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 32df9809dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

parkjinman98 and others added 2 commits November 4, 2026 18:54
Retain main version 0.0.7 and tiled OBB behavior; apply exact face-specific patch without guards duplication.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…ir behavior

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 32df9809dd

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@parkjinman98

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact head c765f8a014c15834bc78274ff2468aeb48ba097d. Integrated release main f6673f689aabf98cac6a26c34d6ca46da887389b (#31 squash and #27 OBB/version 0.0.7) plus latest #32 87ff416621104842889e9661757455b3101a85ac, using merge commits with no force-push. Both integrations were conflict-free. OBB package, CLI routing and eval_dota paths are identical to main; version remains 0.0.7.

Previous integrated head 32df980 completed code review with no findings and security review completed under the stated main-tracking utility policy. All first-round threads remain resolved; wrapper-only exports and unsupported ReID compile clarification preserved.

Please check latest dependency integration and unchanged ReID12 model/YAML behavior. Full CPU suite from the intended worktree: 1688 passed, 15 skipped, 19 deselected, including 595 baseline variants and classifier marker, face/ReID protocol, symlink and concrete preprocessing tests. Merge is coordinated after #32; no PR merge performed here.

@parkjinman98

Copy link
Copy Markdown
Contributor Author

@codex review

Re-request after transient GitHub push error/retry: branch refs now point to exact head c765f8a014c15834bc78274ff2468aeb48ba097d. Please review that SHA, not cached prior 32df980. The immediately preceding guide describes the release-main/face dependency integrations and 1688-pass CPU validation. No code changes beyond those integrations.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: c765f8a014

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: c765f8a014

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@parkjinman98
parkjinman98 deleted the branch feat/face-verification-c2 November 5, 2026 01:29
@parkjinman98 parkjinman98 reopened this Nov 5, 2026
@parkjinman98
parkjinman98 changed the base branch from feat/face-verification-c2 to main November 5, 2026 01:30
Resolve face-verification conflicts to the squash-merged main versions and retain the twelve published CLIP-ReID configurations and documentation.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@parkjinman98

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 45fac2076191f3abb94228bdd83e64bff6d49dff.

This is a main-sync merge after #32 was squash-merged as 7c8ce909974f35fcd23e4c278976a62c74190351; no force-push. #33 was reopened and retargeted to main after deletion of its old stacked base. Dependency conflicts take main’s face-verification versions, preserving its manifest hardening and tests. The ReID-only binary patch is byte-identical to the prior exact-head-reviewed scope (87ff416..c765f8a).

Scope: twelve published CLIP-ReID configs, person_reid processing base and model-only exports/discovery, metadata/parity tests, and related guides (20 files). Check RN50/ViT preprocessing, dataset and embedding dimensions, MXQ-only ONNX guard, registry behavior, and that no #32 or unrelated behavior regresses. Keep revision: main; no release/tag or new compile/CLI route.

Validation: full offline CPU pytest 1695 passed, 15 skipped, 19 deselected; targeted regression subset 676 passed; pinned full-tree Ruff lint and both changed-file pre-commit hooks pass. Main has nine unrelated baseline formatting deviations, intentionally left outside this PR.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 45fac20761

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 45fac20761

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@parkjinman98
parkjinman98 merged commit baa7cf5 into main Nov 5, 2026
3 checks passed
@parkjinman98
parkjinman98 deleted the feat/published-reid-d2 branch November 5, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant