Conversation
Pin the shared transcript reader and use its field extraction for provider error responses. Preserve existing TLSN/MPZ runtime dependencies. Assisted-by: GPT-6 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
This was referenced Sep 10, 2026
SupremaLex
added a commit
that referenced
this pull request
Sep 11, 2026
Every comment, doc comment, README paragraph, example-file comment and test doc in the crate now states the current behaviour or the meaning of a value. History, rationale and review narration are removed. `src/routes/github_token/transcript.rs` is left as is (#11 edits it). Assisted-by: Claude Fable 5.1 Signed-off-by: SupremaLex <georglutsenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token-response layout construction and provider-error classification assumed compact JSON. Pin the whitespace-aware shared transcript reader from libid-rs #20, and classify the actual
errorfield instead of searching raw response text. Reveal whitespace at its original offsets and commit only the bearer value.Based on #8, which introduces the GitHub exchange;
maindoes not contain that code. This PR is independent of callback-artifact retrieval (#9) and localhost/RC3 integration (#10), and preserves #8’s TLSN/MPZ pins.Specification prerequisite: libid spec #32. Companion readers/verifiers: ceremony #28, contracts #36.
Validation: all 20 token-route tests pass on this independent branch using the pinned Rust revision; security/correctness, API and simplicity reviews are clear. This does not claim live OAuth or released-verifier qualification.