Conversation
Preserve original transcript offsets and bearer-only commitments while accepting JSON whitespace around colons and before integer terminators. Assisted-by: GPT-6 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
This was referenced Sep 10, 2026
xgreenx
added a commit
that referenced
this pull request
Sep 11, 2026
The quoted member and the bare integer each walked the body for `"field"` followed by a colon with a copy of the same loop; `key_and_value` is that loop once, handing back the key's opening quote and the value's first byte. The doc on `find_json_snippet_range` still argued for the compact template the reader no longer requires; it now argues for the allowance the reader's whitespace removal maps onto the literal. Tests carried over from #20: every RFC 8259 whitespace byte alone and as a run on both sides of the colon and before the terminator, the bytes JSON does not call whitespace (VT, FF), a number of another shape, chunk framing that lands inside the whitespace, and the token response's delimiter revealed with its whitespace while the bearer alone is committed. Co-authored-by: Wondertan <hlibwondertan@gmail.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: xgreenx <xgreenx9999@gmail.com>
Contributor
|
Closing in favor of #21, which now carries everything from here: the one shared scan for both member shapes ( The byte ranges the two branches cut are identical, so nothing changes for a consumer. The verifier side that merged is libid-org/libID-contracts#37 (whitespace removed on chain before matching), the same reason #36 closed. libid-server-rs#11 pins this branch's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub’s real identity response can contain whitespace after JSON colons. The transcript reader previously rejected these valid responses. Accept JSON whitespace around field colons and before integer terminators for token and identity layouts, preserving original reveal offsets and bearer-only commitments.
Validation: all 54 libid-transcript tests pass, including original-byte range checks and chunk-split rejection. This needs the matching TypeScript and verifier changes; the proof circuit is unchanged.
Specification: libid #32. Standalone Bridge fix: libid-server-rs #11, based only on the token-exchange prerequisite (#8).