fix(bridge): classify GitHub OAuth errors with JSON whitespace - #10
Merged
Merged
Conversation
xgreenx
approved these changes
Sep 10, 2026
Wondertan
changed the title
SupremaLex
force-pushed
the
feat/callback-artifact-retrieval
branch
from
September 11, 2026 11:34
ebbf109 to
31f3b70
Compare
SupremaLex
added a commit
that referenced
this pull request
Sep 11, 2026
Production: - `ON_EVERY_RESPONSE`: the `no-store` and `nosniff` pair, declared once in `routes` and carried by the health, callback, configuration and token responses. - `Published::log`: the one log line naming a document's URL, validator and policy, at retrieval and at replacement. Tests: - `tests/http.rs`: one request builder (`token_request`), one body builder (`token_body_with` / `token_body_without`), one permit-holding poster; `post_token` takes the origins as a list. - `session.rs`: one assembly helper over a duplex socket, with the notary's behaviour as an enum; one bearer opening. - `request.rs`: one layout helper. `upstream.rs`: one deployed-Distribution helper. jscpd: 12 clones, 66 lines → 1 clone, 5 lines; the one left is `redirect_uri` beside `notary_host` (#10's function, kept verbatim). Assisted-by: Claude Fable 5.1 Signed-off-by: SupremaLex <georglutsenko@gmail.com>
Use released libid-rs v0.3.0 and the matching TLSN/MPZ pins, including the MPZ active-context lifetime fix. Assisted-by: GPT-6 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
Pin the shared Rust transcript reader and classify the actual error field using the same reader. Assisted-by: GPT-6 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
Wondertan
force-pushed
the
feat/localhost-http
branch
from
September 11, 2026 16:28
dc25146 to
e375d86
Compare
Wondertan
changed the title
Replace the closed whitespace PR dependency with its released successor while retaining the matched RC3 TLSN and MPZ runtime patches. Assisted-by: GPT-6 Signed-off-by: Wondertan <hlibwondertan@gmail.com>
Wondertan
changed the title
xgreenx
approved these changes
Sep 14, 2026
SupremaLex
added a commit
that referenced
this pull request
Sep 14, 2026
Production: - `ON_EVERY_RESPONSE`: the `no-store` and `nosniff` pair, declared once in `routes` and carried by the health, callback, configuration and token responses. - `Published::log`: the one log line naming a document's URL, validator and policy, at retrieval and at replacement. Tests: - `tests/http.rs`: one request builder (`token_request`), one body builder (`token_body_with` / `token_body_without`), one permit-holding poster; `post_token` takes the origins as a list. - `session.rs`: one assembly helper over a duplex socket, with the notary's behaviour as an enum; one bearer opening. - `request.rs`: one layout helper. `upstream.rs`: one deployed-Distribution helper. jscpd: 12 clones, 66 lines → 1 clone, 5 lines; the one left is `redirect_uri` beside `notary_host` (#10's function, kept verbatim). Assisted-by: Claude Fable 5.1 Signed-off-by: SupremaLex <georglutsenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub token errors containing JSON whitespace, such as
{"error": "incorrect_client_credentials"}, were missed by the literal"error":"search and reported as an unusable response/MPC-TLS failure. Separately, searching the entire transcript for"bad_verification_code"could classify a response using text outside theerrorfield.Read the actual
errorfield with the shared whitespace-awareJsonMemberreader instead. Its value determines the existing failure category:bad_verification_code: the authorization code was refused; the caller should start a fresh ceremony.incorrect_client_credentialsandredirect_uri_mismatch: report a deployment configuration problem.errorfield and no bearer: retain the unusable-response failure.Classification still returns the Bridge's own messages; GitHub's raw response is not forwarded. The shared reader comes from released libid-rs v0.4.0, with the TLSN/MPZ pins kept compatible with notary v0.3.0-rc.3.
This started as a localhost HTTP support PR. That support is now in the base branch, so the remaining change has shifted entirely to GitHub error handling and its dependency updates.