[ryota-murakami]

{
  "schema_version": 1,
  "pr": 144,
  "head": "ad13920cd16fe8406df662eab904c56b087b843b",
  "version": "0.2.53.0",
  "base": "main",
  "gate": {
    "tests": {
      "pass": 7911,
      "fail": 0,
      "skip": 10
    }
  },
  "session_kind": "interactive",
  "pregate": "pass @63551db80431 (6 checks, current for ad13920cd16f)",
  "issues": {
    "fixes": [],
    "refs": [
      143
    ],
    "flakes": []
  },
  "docs": {
    "status": "updated",
    "scope": "AGENTS.md, CHANGELOG.md, PRODUCT_GOAL.md, README.md, extension/README.md, extension/skills/codebook/SKILL.md, the v9 PNG (audit c58-docs-20261027T230828Z)"
  },
  "review_loop": {
    "passes": 3,
    "blocking_found": 0,
    "deferred": 0,
    "noted": 0,
    "fixed": 6,
    "scope": "frozen"
  }
}

Summary

Cycle 0057 shipped live explanation of a repository's own Node HTTP server, and its review left 13 defects that this bug-fix cycle closes (Refs #143). Stopping a server could record a SIGKILL it never sent, retry a signal on a process identified by its folder alone, or let a pause during the debugger's release run on until SIGTERM. The chat could read a GET described as changing nothing, a … n more bytes count taken from two different texts, and a 15-minute limit that never fires. With the database down it named no cause, and the LLM Wiki view's message flickered empty when a watch stopped.

Now a stop signals only the process group it started, confirmed by its start time before SIGTERM and again just before SIGKILL, which still lands within 5 s. It journals exactly what it sent and ends a server that pauses during the release at once. The tool text, help and packaged README say what the run really does. Skill 1.0.52 makes the chat read the run's output before it attributes a failure; in the N58 trial it named a refused database connection as observed output. The Wiki view keeps its message until the next one replaces it.

Blast radius

The changes stay inside the node-server run (launcher close, identity check, orphan sweep, VS Code debugger, request sender), its help and tool text, the bundled skill text and the LLM Wiki view's message. Browser and test runs, saved studies, replays and stored formats are untouched. The orphan record keeps its schema (its cwd field stays so records parse across versions), and the MCP API stays 1.8. Evidence: the full suite (7,920 tests) and the package tests pass on the final head, and the pinned-clone real-process tests pass 4/4 against laststance/switch-time and laststance/nsx with their databases (script ran).

Test Coverage

All new code paths have test coverage: every task closed red first (the fixed source swapped back fails its test), and every review fix after that too.

Tests: 7,911 → 7,920 on the full suite (+9 from the review fixes; the cycle's parts added the rest before /ship).
Coverage: 100% value-weighted (100% including 0 weakly covered paths)
Test value: 0 tests written, 1 rejected by the authoring gate, 1 existing test extended, 0 paths weakly covered.
Tests ran: tests count unavailable (runner summary on the final head: 7,921 tests, 7,911 pass, 0 fail, 10 skipped)

Pre-Landing Review

Three review passes, each fixing every finding (a bug-fix cycle answers none Skip), reaching the ship review limit with converged:false:

• Pass 1 (6 specialists + red team): 4 informational findings, all fixed red first: the LLM Wiki view kept a message with no bound, a late SIGKILL could follow a close that had returned or a group that had ended, and the orphan record's cwd doc.
• Pass 2: 1 red-team finding fixed (the kept message now follows the marker change's real pending state, not a timer).
• Pass 3: 1 maintainability finding fixed (a test helper's doc comment).
• Step 11 adversarial: the Codex structured review found [P1] a retried stop's SIGKILL after a group-existence probe alone (an id reused by another group could be killed). Fixed: the second identity check now starts 1 s before the kill bound, and a group found replaced, or a check that has not answered by then, gets no SIGKILL. Codex adversarial also found a stop during the release dropped by a following continued (now reported at once) and a Wiki facts read mixing two moments (now judged in one turn). The Claude adversarial pass led to a clearer message for a body that cannot be shown. All were reproduced red before the fix.

Every last-round finding is fixed, and no Critical or Major defect stays open, so no Issue records one. The local CodeRabbit CLI then found one more minor finding on the final range, fixed red first (0ca807e1); its rerun found none.

REVIEW_LOOP: 3 passes, converged:false (ship review limit), all findings fixed.

Gate edits: 51 listed, 31 read, 0 findings (patterns: RH-1,RH-3,RH-4,RH-12,RH-13,RH-14,RH-15,RH-16; unlisted idioms: none)

• RH-16 extension/src/ownedNodeServerRun.ts: kept. The late SIGKILL's catch is best effort; the close's own SIGTERM and SIGKILL sequence still ends the group.

Outside review: Codex (structured and adversarial) completed; its findings are fixed above.

Exploratory QA

Functional smoke on each review pass, through the repository's own compiled tests (no editor, no database): the launcher's real fixture server, the run's host harness and the Wiki view with the real facts reader passed on every pass. The native editor check N58 passed on the pre-review candidate 6473c5c3 in VS Code (details in #143); it did not run again on the review fixes.

Design Review

No frontend files changed — design review skipped.

Eval Results

No prompt-related files changed — evals skipped. The bundled skill's text changed (1.0.52); its tests and the N58 native check cover it.

Scope Drift

Scope Check: CLEAN (tasks 1–14 of #143; the review fixes stay inside them).

Plan Completion

Tasks 1–13 done, each with a red-first test; task 14 (N58) PASS on 6473c5c3. The 15-check exact-HEAD gate and the local CodeRabbit CLI passed on the final head (below).

Linked Spec

Linked to #143 (the cycle Issue; closed by hand after merge with its closing comment). Spec archive: 20261028-065450-32319-cycle-0058-a-stopped-or-retried-server-run-does-only-what-it.md, filed 2026-10-28.

Issues

Refs #143

Verification Results

On the final head ad13920c:

• 15-check exact-HEAD gate: every check exit 0 (format, typecheck, lint, health:static, dupes, dead-code; the suite 7,921 tests, 7,911 pass, 0 fail, 10 skipped; the five Reader DOM checks; test:package 1,081 / 1,071 / 0 / 10; health 86 A; the restore-context hook test 9/9).
• Local CodeRabbit CLI on the final range: 1 minor finding (a Wiki marker read while the run ran, when the run and its marker change both ended during the read) fixed red first in 0ca807e1; the rerun on that tree found 0. ad13920c has the same tree.
• Pinned-clone real-process tests: 4/4 on afbf15ff; the run and launcher are unchanged since.
• VSIX packaged and checked (0.2.53, skill 1.0.52).

The Node 26.12.1 pin bump (the owner's commit 12672469) landed on this branch. On it, CI's health check refused (its reference pins Node 24.21.0) and four tests failed on Node 26. On the owner's decision it is kept unchanged on its own draft PR #145, where the Node 26 migration happens, and reverted here (ad13920c), so this PR merges on the verified Node 24.21.0.

TODOS

No TODO items completed in this PR.

Documentation

Status: updated. One factual edit, no blockers.

Scope: base 333c781 through the committed, staged and unstaged tree of codex/cycle-0058 (CHANGELOG.md, VERSION, extension/README.md, extension/package.json, constants.ts, protocol.ts, nodeServerHelp.ts, skill 1.0.52 and tests), plus the spec .gstack/tmp/c58/issue-body.md. Discovery covered root README.md, AGENTS.md, PRODUCT_GOAL.md, docs/agents/*.md, extension/README.md and extension/skills/codebook/SKILL.md; fixtures were excluded.

Documentation health:

• README.md: Updated. The Implementation status paragraph named 0.2.52.0 as pending the merge of pt3, which has merged; it now names 0.2.53.0 (Cycle 0058, Issue Cycle 0058: a stopped or retried server run does only what it reports, and what the chat reads about it is true #143) as the version delivered on merge, 0.2.52.0 (PR v0.2.52.0 feat: /codebook sends server and API questions to the live server run, and a stop never signals a process it cannot confirm (Cycle 0057 pt3) #142) as the current one, and adds a one-sentence Cycle 0058 summary.
• extension/README.md: Current. It already carries a sentence for every user-visible behavior of the 0.2.53.0 entry (late-pause SIGKILL, start-time-only identity, pre-SIGKILL check, closed record killed, orphan keep and report, STALE_PAUSE on continue while stopping, one request time limit with RUNTIME_FAILED, the GET sentence, remainder byte count, REQUEST_FAILED message, skill 1.0.52, LLM Wiki view message) and matches the code read (protocol.ts, nodeServerHelp.ts, sendDeclaredRequest.ts, constants.ts).
• CHANGELOG.md: Current, not edited. Matches the code and README.
• AGENTS.md, PRODUCT_GOAL.md, v9 PNG: not edited by rule.
• extension/skills/codebook/SKILL.md: Current (version 1.0.52 matches the README and CHANGELOG).

Coverage debt: none; all shipped behaviors have reference coverage in extension/README.md, the node-server help resource and the CHANGELOG. No how-to or tutorial pages were required for this bug-fix cycle. Diagram drift: none; no architecture diagrams in the audited docs.

Test plan

• cd extension && corepack pnpm test: 7,921 tests, 7,911 pass, 0 fail, 10 skipped (gate on ad13920c)
• cd extension && corepack pnpm test:package: 1,081 tests, 1,071 pass, 0 fail, 10 skipped
• CODEBOOK_NODE_SERVER_CLONES=… node --test extension/dist/tests/ownedNodeServerRun.pinnedClones.test.js: 4/4 pass
• node extension/scripts/package.mjs + check-package.mjs: exit 0
• 15-check exact-HEAD gate on ad13920c: every check exit 0
• local CodeRabbit CLI on the final range: 0 findings after the fix
• required CI on ad13920c (merge waits for it)

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: laststance/codebook
• Branch: codex/cycle-0058
• File: .coderabbit.yaml
• Commit: ad13920
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: a6e30396-9c51-451b-b4a8-ed7aebf0c516

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}