Skip to content

chore(ci): bump Node.js to 26.12.1 (needs the Node 26 migration before merge) - #145

Closed
ryota-murakami wants to merge 1 commit into
mainfrom
codex/node-26
Closed

ryota-murakami wants to merge 1 commit into
mainfrom
codex/node-26

Conversation

@ryota-murakami

Copy link
Copy Markdown
Contributor

Summary

Moves the project's Node pin to 26.12.1 (.node-version and package.yml). The commit is the owner's, taken unchanged from the Cycle 0058 branch, where it was split off so that Cycle 0058 (PR #144) merges on the verified Node 24.21.0 (owner decision, Refs #143).

What this needs before it can merge

CI on Node 26.12.1 is expected to fail until this work is done here:

  • Health baseline: pnpm --dir extension health refuses because extension/fallow-health-reference.json pins Node 24.21.0 and the old .node-version hash. AGENTS.md: retake the measured baseline from 944c1342 in a separate worktree with the new pins, record the hashes in the reference (health.test.mjs pins it), and say so in this PR.
  • Tests that fail on Node 26.12.1 (they pass on 24.21.0, seen on the Cycle 0058 branch's CI and locally):
    • fakeClock.test.js: "a wait spends no fake time while a real file read is pending", "advancing the fake clock spends no fake time while a real file read is pending"
    • claimWikiUpdateMarker.test.js: "links beside the marker that the system refuses to unlink are left in place when they are older than 60 s …"
    • isFolderOfItsOwn / folder listing (CI shard 9): "a folder of its own is listed with everything below it, and a link below it is named and not entered"
  • Recheck every other pin that names Node 24 (for example the inspector-line and runner-output tests that mention Node 24.21).

Test plan

  • Root cause of each Node 26 failure fixed in the product or the test, red first
  • Health baseline retaken with the new pins; pnpm --dir extension health exit 0
  • Required CI green on Node 26.12.1

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

ryota-murakami added a commit that referenced this pull request Oct 27, 2026
The bump (1267246) is kept unchanged on codex/node-26 (PR #145), where the
Node 26 migration it needs (four failing tests, the health baseline retaken
with the new pins) happens. Cycle 0058 merges on the verified Node 24.21.0
(owner decision, Refs #143).

This reverts commit 1267246.
ryota-murakami added a commit that referenced this pull request Oct 27, 2026
…rts, and what the chat reads about it is true (#144)

* fix: Cycle 0058 B: truthful response count, GET text, settled response, one request limit, skill 1.0.52 (Issue #143)

* fix: Cycle 0058 A: a stop records and signals exactly what it did, a folder alone never authorizes a signal, and a pause during the detach is ended (Issue #143)

* fix: Cycle 0058 C: the LLM Wiki view keeps the watching message until the stopped-watch message replaces it (Issue #143)

* test: Cycle 0058: the journal-bounds test pins its kept bytes; the kill-bound assertions name why their bounds are the contract (Issue #143)

nodeServerJournalBounds.test.ts kept a debugging console.log and no fixed
expectation (task 11 asks for a hard-coded byte count): it now asserts the
4,190,377 kept bytes two full runs measured, beside the upper bound.
launchNodeServer.test.ts: gstack-timing-ok notes on the SIGKILL bound and the
SIGTERM-before-SIGKILL order (comments only).

Refs #143

* fix: pre-landing review fixes (Cycle 0058 /ship pass 1, Refs #143)

- The LLM Wiki view keeps its message only while this window's marker
  settles: the own live marker counts as settling for 10 s after the run's
  end (the first retry of a failed marker change), and the view polls while
  it keeps a message, so a marker left standing never keeps "watching the
  chat" on screen (core review and red team).
- A late pause during a stop's detach is ended only while that release's
  close is under way and the group still has members: a retry's identity
  check that answers after the close returned, or a group that already
  ended, signals nothing (state-machines specialist, red team).
- The orphan record's cwd field says why it stays: no identity input, kept
  so records parse in every version (maintainability specialist).
- The coverage audit's facts test now covers the bounded settle.

* fix: pre-landing review fixes, pass 2 (Cycle 0058 /ship, Refs #143)

The LLM Wiki view keeps its message exactly while this window's change of
its marker is pending (from the turn the run's end is recorded until the
change is made or given up, retries included), instead of for 10 s after
the run's end: a first change that failed no longer empties the message
before its retry turns the marker into the reservation, and a change
given up still clears it, through the view's own read at that end. The
extra poll of pass 1 is gone (red team, pass 2).

* test: Cycle 0058 /ship pass 3: the own-marker helper's doc names its real start (Refs #143)

* fix: Cycle 0058 /ship Step 11 adversarial findings (Refs #143)

- A retried stop confirms the group again before SIGKILL: the second
  identity check starts NODE_SERVER_KILL_CHECK_LEAD_MS (1 s) before the
  kill bound, so SIGKILL goes only to a group confirmed then and still
  lands by the bound; a group found replaced gets nothing, and a check
  that has not answered by the bound sends nothing and fails the close
  (Codex structured P1, Codex adversarial High).
- The VS Code debugger reports a stop of the bound session that arrives
  after its release began in the turn it arrives, so a `continued` from
  the detach cannot drop it before the run ends the group (Codex
  adversarial).
- The LLM Wiki facts judge this window's marker settle in the same turn
  as the run facts, so a run that ends during the read keeps the view's
  message (Codex adversarial).
- A response body that cannot be prepared for display says that the
  server answered and with which HTTP status (Claude adversarial).

* docs: Cycle 0058: README sentences for 0.2.53.0's server-run behavior and the delivered version (Refs #143)

* chore: bump version and changelog (v0.2.53.0)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: Cycle 0058: a Wiki marker read while the run ran keeps the view's message once the run ended during the read (local CodeRabbit CLI, Refs #143)

* chore(ci): bump Node.js to 26.12.1 in GitHub Actions and project pins

* revert: move the Node 26.12.1 bump to its own pull request (#145)

The bump (1267246) is kept unchanged on codex/node-26 (PR #145), where the
Node 26 migration it needs (four failing tests, the health baseline retaken
with the new pins) happens. Cycle 0058 merges on the verified Node 24.21.0
(owner decision, Refs #143).

This reverts commit 1267246.

---------

Co-authored-by: Claude <noreply@anthropic.com>
@ryota-murakami
ryota-murakami deleted the codex/node-26 branch October 28, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant