Repository navigation
fix(native): preserve startup after Dreamer failure and bound scheduled input - #261
Conversation
joshyorko
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 565c407747
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Checkpoint published at This checkpoint adds only the managed-container readiness regression tests in Verified against the unchanged production implementation with pinned Rust/Cargo 1.88:
The four findings from completed automatic review 5396999862 remain unresolved: container host/guest DB path, exact profile/workspace pair, absolute scheduler deadline across sizing retries, and whole-evidence sizing without ASCII-tail truncation. No fixes for those findings are included in this checkpoint. Earlier full-suite/CI green evidence applies to Private prompts, reports, databases, credentials, logs, caches and builder artifacts were excluded from publication. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bfe494589
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the current head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c94d1a6f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2d9f66a4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83149509d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review latest head 4d9424f, including the late-frontier evidence and resolved container MCP database fixes. Latest-head hosted CI is green. This request is within Josh's authorization for the remaining review cycles needed to qualify this PR; no merge, release, or deployment is requested. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d9424f247
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01b24b2282
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review latest head e5bcd6b, including restored/promoted record versions, current-window candidate generation, and equal-clock completed frontiers. Exact-head hosted PR gate 38622245498 passed. This is within Josh's authorized remaining latest-head review cycles. No merge, release, or deployment is requested. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5bcd6b6a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 720f0f1be8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review exact latest head a97105e. Hosted PR gate 38636928009 passed. This pass audits scheduler cursor transitions and existing-record mutation paths, including unbounded-to-bounded arrivals, consolidation reuse/undo, provenance updates, supersession, restore and promotion. Please assess the resulting invariants and any actionable remaining regressions. This request is within Josh's authorized remaining latest-head review cycles. No merge, release or deployment requested. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a97105e614
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review exact latest head 49ea61e. It addresses review5524825877 with persistent non-reusable scheduler insertion frontiers and full record hydration inside the frontier-filtered query. Regression coverage includes hard-delete/reinsert, persisted cursor migration, and deterministic concurrent updates. Local full release gate passed (610 tests); hosted PR gate38642395324 is running. Please identify actionable correctness regressions. This is the authorized latest-head review before merge; no deployment or release requested. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49ea61e1b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review exact head 7717d40. The two findings in review 5525183621 are addressed by an immediate transaction covering logical-rowid migration and saved-cursor high-water initialization, with a completion marker to avoid rescanning history on subsequent opens. Concurrent-write/reopen regressions, schema upgrade tests, native isolation, and the full local release gate passed. Hosted gate 38645873076 is running. This is the authorized latest-head review before merge. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Fixes #260.
Repair
This preserves the existing PR implementation and addresses the four reported Codex findings:
Follow-up fixes keep container mounts aligned with configured paths, preserve late rows at scheduler frontiers, retain completed rowid frontiers when the simulated clock does not advance, and track active-memory update versions so restore/promotion of an existing row remains eligible after its insertion rowid has been scanned. Comparison-only memories remain bounded context and cannot emit stale or supersession candidates without current evidence. Recovered deterministic command fallbacks save a status-visible
ok_with_limitsreceipt while retaining the provider budget rejection in audit history. Scheduled commands remain preview-only; provider authentication and configured resource limits remain enforced.Verification at
e5bcd6b6a1e92ed3c8c9361ecb41fdd66f983a829ed1ecd777072029babac4c046f2f64db886bcb6merged cleanly: MCP daemon 10/10 and CLI smoke 126/126, including the resolved database symlink path.All verification used synthetic or disposable data.
History and review
This continues PR #261 on its existing branch and includes current
master, including #266 merge2422cd376956b6ead2bfc8b40bd853d953c618e0. The latest connector review on01b24b2282327ae7a6cd495c13474c496180cb5fraised three actionable findings; all three are addressed ine5bcd6b6a1e92ed3c8c9361ecb41fdd66f983a82and their threads are resolved. The automatic connector review for this exact head is pending; wait for it before merging.