Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #238 Packet A and fixture P14. Depends on #261's bounded command scheduler repair.
With a manual apply watermark but no scheduled watermark, the first scheduled command incorrectly inherited the manual cutoff, returned an empty success, and advanced past scheduler-unprocessed evidence. The private scheduled invocation now keeps its own empty or persisted cutoff. Manual omitted-cutoff defaults and explicit manual replay retain their behavior; the scheduler does not gain archive replay authority.
A file-backed service regression establishes the two independent watermarks through real operations, checks a failed command and persisted error receipt, reopens the database, retries the same first record, continues a capped equal-timestamp source tail across another restart and a later manual watermark, and verifies no archived evidence or unchanged-tick model call. Separate compatibility checks retain manual default and explicit-empty behavior.
Base: 4972855, the published #261 head.
Tested local checkpoint: f1cb612bda4769bbd64d2796f2e37b680abcfc9e.
Published head: 5b1da23. The published and tested trees are identical: 73482fc775544b638809e5220969d06c7eaaff82.
Validation:
This bounded repair does not close #238 or claim governed automatic model adoption, semantic validation, real consumer learning acceptance, or live activation. No provider/model/auth ownership, budgets, proposal identity, schema, storage policy, or adoption mode changes are included. Latest-head automatic connector review and required checks remain merge gates; no additional GitHub review was requested.
Independent local Sol review found no actionable bounded finding. The completed full synthetic gate covers the identical published tree
73482fc775544b638809e5220969d06c7eaaff82. This remains a draft stacked on #261. Latest-head GitHub CI and automatic connector review remain pending; complete #238 adoption and consumer gates remain open.