Repository navigation
fix(firestore,pubsub): align types and proto re-exports with -api packages - #9621
Merged
Merged
Conversation
quirogas
added this pull request to stack #9623
October 14, 2026 15:03
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TypeScript definitions in handwritten/firestore/types/firestore.d.ts to explicitly define the structure of the deprecated v1beta1 export, mapping its FirestoreClient to a local import path instead of importing the entire namespace from @google-cloud/firestore-api. There are no review comments to address, and I have no additional feedback to provide.
danieljbruce
approved these changes
Oct 15, 2026
danieljbruce
left a comment
danieljbruce
left a comment
Contributor
There was a problem hiding this comment.
I like this change, particularly the pubsub proto removals. I was surprised to see handwritten/firestore/types/firestore.d.ts wasn't autogenerated since a similar file in bigquery-storage is autogenerated.
…kages ## Description Align handwritten `@google-cloud/firestore` type declarations and `@google-cloud/pubsub` proto re-exports with their underlying workspace `-api` packages (`@google-cloud/firestore-api` and `@google-cloud/pubsub-api`). ## Impact Eliminates cross-package type declaration drift and duplicate static protobuf definitions between handwritten veneer packages and their generated `-api` packages, unblocking workspace dependency linking (`Part 1 of 2` in the internal dependency floor stack). ## Changes - Update `handwritten/firestore/types/firestore.d.ts` so `FirebaseFirestore.v1beta1` references the local `./v1beta1/firestore_client` `FirestoreClient` declaration rather than a non-existent `v1beta1` export on `@google-cloud/firestore-api`. - Replace the duplicate static protobuf bundle in `handwritten/pubsub/protos/protos.js` and `handwritten/pubsub/protos/protos.d.ts` with direct re-exports from `@google-cloud/pubsub-api/build/protos/protos`. ## Testing - Compiled `handwritten/firestore` and `handwritten/pubsub` cleanly with zero TypeScript errors. - Verified strict repository linter checks (`GIT_DIFF_ARG=origin/main node ./bin/linter.mjs --strict`). ## Alternatives - Maintaining duplicate static protobuf code and out-of-sync `.d.ts` exports in `handwritten/firestore` and `handwritten/pubsub` was rejected because it causes TypeScript compilation failures when workspace packages link to current `-api` packages.
quirogas
force-pushed
the
fix/firestore-pubsub-api-drift
branch
from
October 16, 2026 04:50
bfd5243 to
2fccf81
Compare
This was referenced Oct 16, 2026
Merged
shivanee-p
pushed a commit
that referenced
this pull request
Oct 19, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>common: 8.2.1</summary> ## [8.2.1](common-v8.2.0...common-v8.2.1) (2026-10-19) ### Bug Fixes * **tools:** Export test-utils types and exempt cloud-profiler on Bun ([#9611](#9611)) ([ec74599](ec74599)) </details> <details><summary>gapic-generator: 5.7.1</summary> ## [5.7.1](gapic-generator-v5.7.0...gapic-generator-v5.7.1) (2026-10-19) ### Bug Fixes * **generator:** Use .jsdoc.json with build/esm/src in ESM template ([#9523](#9523)) ([0131ab8](0131ab8)) </details> <details><summary>gapic-node-processing: 0.3.1</summary> ## [0.3.1](gapic-node-processing-v0.3.0...gapic-node-processing-v0.3.1) (2026-10-19) ### Bug Fixes * **generator:** Use .jsdoc.json with build/esm/src in ESM template ([#9523](#9523)) ([0131ab8](0131ab8)) </details> <details><summary>google-gax: 6.13.0</summary> ## [6.13.0](google-gax-v6.12.1...google-gax-v6.13.0) (2026-10-19) ### Features * **gax:** Add LoggerHelper with context helper ([#9631](#9631)) ([c410f90](c410f90)) * **gax:** Remove references to static telemetry information ([#9630](#9630)) ([8954cff](8954cff)) </details> <details><summary>gcp-metadata: 9.2.2</summary> ## [9.2.2](gcp-metadata-v9.2.1...gcp-metadata-v9.2.2) (2026-10-19) ### Bug Fixes * **gcp-metadata:** Recognize Bun socket error codes in isAvailable ([#9613](#9613)) ([0fb3dee](0fb3dee)) </details> <details><summary>precise-date: 6.2.1</summary> ## [6.2.1](precise-date-v6.2.0...precise-date-v6.2.1) (2026-10-19) ### Bug Fixes * **tools:** Export test-utils types and exempt cloud-profiler on Bun ([#9611](#9611)) ([ec74599](ec74599)) </details> <details><summary>projectify: 6.2.1</summary> ## [6.2.1](projectify-v6.2.0...projectify-v6.2.1) (2026-10-19) ### Bug Fixes * **tools:** Export test-utils types and exempt cloud-profiler on Bun ([#9611](#9611)) ([ec74599](ec74599)) </details> <details><summary>promisify: 6.2.1</summary> ## [6.2.1](promisify-v6.2.0...promisify-v6.2.1) (2026-10-19) ### Bug Fixes * **tools:** Export test-utils types and exempt cloud-profiler on Bun ([#9611](#9611)) ([ec74599](ec74599)) </details> <details><summary>test-utils: 0.3.1</summary> ## [0.3.1](test-utils-v0.3.0...test-utils-v0.3.1) (2026-10-19) ### Bug Fixes * **tools:** Export test-utils types and exempt cloud-profiler on Bun ([#9611](#9611)) ([ec74599](ec74599)) </details> <details><summary>bigquery: 9.4.0</summary> ## [9.4.0](bigquery-v9.3.0...bigquery-v9.4.0) (2026-10-19) ### Features * **bigquery:** Add createQueryArrowStream for inline jobs.query results ([#9596](#9596)) ([69157ed](69157ed)) </details> <details><summary>pubsub: 6.3.1</summary> ## [6.3.1](pubsub-v6.3.0...pubsub-v6.3.1) (2026-10-19) ### Bug Fixes * **firestore,pubsub:** Align types and proto re-exports with -api packages ([#9621](#9621)) ([25d945b](25d945b)) </details> <details><summary>aiplatform: 7.7.0</summary> ## [7.7.0](aiplatform-v7.6.0...aiplatform-v7.7.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>alloydb: 3.5.0</summary> ## [3.5.0](alloydb-v3.4.0...alloydb-v3.5.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>compute: 7.9.0</summary> ## [7.9.0](compute-v7.8.0...compute-v7.9.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>contact-center-insights: 5.3.0</summary> ## [5.3.0](contact-center-insights-v5.2.0...contact-center-insights-v5.3.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>dataproc: 7.3.0</summary> ## [7.3.0](dataproc-v7.2.0...dataproc-v7.3.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>datastream: 5.3.0</summary> ## [5.3.0](datastream-v5.2.0...datastream-v5.3.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>memorystore: 0.12.0</summary> ## [0.12.0](memorystore-v0.11.0...memorystore-v0.12.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>pubsub-api: 0.8.0</summary> ## [0.8.0](pubsub-api-v0.7.0...pubsub-api-v0.8.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>redis-cluster: 0.17.0</summary> ## [0.17.0](redis-cluster-v0.16.0...redis-cluster-v0.17.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>security-center: 10.3.0</summary> ## [10.3.0](security-center-v10.2.0...security-center-v10.3.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>developer-knowledge: 0.10.0</summary> ## [0.10.0](developer-knowledge-v0.9.0...developer-knowledge-v0.10.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> <details><summary>cloudbuild: 6.3.0</summary> ## [6.3.0](cloudbuild-v6.2.0...cloudbuild-v6.3.0) (2026-10-19) ### Features * Update API sources and regenerate ([#9620](#9620)) ([c812bc3](c812bc3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
MarkDuckworth
pushed a commit
that referenced
this pull request
Oct 22, 2026
🤖 I have created a release *beep* *boop* --- ## [9.4.0](firestore-v9.3.1...firestore-v9.4.0) (2026-10-22) ### Features * **firestore:** Add DML stages (insert, upsert, delete, update), literals source, and atomic execution option to Node SDK pipelines ([2639650](2639650)) ### Bug Fixes * **firestore,pubsub:** Align types and proto re-exports with -api packages ([#9621](#9621)) ([25d945b](25d945b)) * **firestore:** Resolve api-extractor from cloud-rad in api-report.mjs ([#9505](#9505)) ([dc83ed8](dc83ed8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up Firestore and Pub/Sub type and proto exports to match their generated
-apipackages:v1beta1export fromhandwritten/firestore/types/firestore.d.ts.protosinhandwritten/pubsub/protos/protos.jsandprotos.d.tsdirectly from@google-cloud/pubsub-apiinstead of keeping a duplicate copy.