Repository navigation
Conversation
In PR googleapis#9621, `handwritten/pubsub/protos/protos.d.ts` was updated to a star re-export (`export * from '@google-cloud/pubsub-api/build/protos/protos'`). Because `handwritten/pubsub/src/index.ts` still imported `../protos/protos` via a local namespace import (`import * as protos from '../protos/protos'`), `@microsoft/api-extractor` failed during `docs-devsite` generation with: `ERROR: The protos namespace import includes a start export, which is not supported` Import `protos` directly from `@google-cloud/pubsub-api` in `src/index.ts` (matching `spanner`, `logging`, `bigtable`, and `bigquery-storage`) while retaining `protos/protos.{js,d.ts}` for direct subpath consumers.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the import source of protos in handwritten/pubsub/src/index.ts to use @google-cloud/pubsub-api instead of a local path. Feedback suggests simplifying the import and export statements into a single direct re-export statement to make the code cleaner and more idiomatic.
Comment on lines
187
to
188
| import {protos} from '@google-cloud/pubsub-api'; | ||
| export {protos}; |
Contributor
There was a problem hiding this comment.
Instead of importing protos and then exporting it on the next line, you can simplify this to a single direct re-export statement. This is cleaner and more idiomatic.
Suggested change
| import {protos} from '@google-cloud/pubsub-api'; | |
| export {protos}; | |
| export {protos} from '@google-cloud/pubsub-api'; |
shivanee-p
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #9621,
handwritten/pubsub/protos/protos.d.tswas updated to a star re-export (export * from '@google-cloud/pubsub-api/build/protos/protos').Because
handwritten/pubsub/src/index.tsstill imported../protos/protosvia a local namespace import (import * as protos from '../protos/protos'),@microsoft/api-extractorfails duringdocs-devsitegeneration with:This updates
handwritten/pubsub/src/index.tsto importprotosdirectly from@google-cloud/pubsub-api(matchingspanner,logging,bigtable, andbigquery-storage), while retaininghandwritten/pubsub/protos/protos.{js,d.ts}for direct subpath consumers.