Repository navigation
Conversation
quirogas
added this pull request to stack #9623
October 14, 2026 15:03
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates dependencies across multiple packages in the repository, bumping versions of core libraries such as @google-cloud/common, @google-cloud/promisify, google-auth-library, and google-gax, alongside updating test scripts to use a centralized test runner. A review comment points out that @google-cloud/promisify was redundantly added to devDependencies in packages/google-cloud-translate/package.json while already being a production dependency.
quirogas
force-pushed
the
chore/upgrade-internal-dep-floors
branch
4 times, most recently
from
October 15, 2026 21:08
e13264f to
b494a6e
Compare
quirogas
force-pushed
the
chore/upgrade-internal-dep-floors
branch
from
October 16, 2026 04:50
b494a6e to
b6ff286
Compare
quirogas
marked this pull request as ready for review
October 16, 2026 19:51
danieljbruce
approved these changes
Oct 16, 2026
danieljbruce
left a comment
danieljbruce
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me. I notice it includes updates to packages folder as well (generated packages) which doesn't align with the title, but maybe those need to be upgraded too anyway.
quirogas
force-pushed
the
chore/upgrade-internal-dep-floors
branch
from
October 16, 2026 20:36
b6ff286 to
12e9fc9
Compare
quirogas
marked this pull request as draft
October 20, 2026 04:25
quirogas
force-pushed
the
chore/upgrade-internal-dep-floors
branch
from
October 20, 2026 04:47
12e9fc9 to
06d6043
Compare
## Description
Upgrade internal core library and handwritten veneer `-api` dependency floors across the monorepo.
## Impact
Aligns internal dependency ranges with current released workspace package versions across CI and local builds.
## Changes
- Upgrade internal `core/` and `@google-cloud/*-api` dependency and `devDependencies` version floors across `core/`, `handwritten/`, `packages/`, `librarian.yaml`, and root `package.json` (including `gaxios@^8.3.1`, `gcp-metadata@^9.2.1`, `google-auth-library@^11.3.1`, `teeny-request@^11.1.1`, and `@google-cloud/bigquery-storage@^6.3.0`), while keeping `@google-cloud/common` pinned to `8.0.1` until `@google-cloud/common@8.2.2` is released.
- Update `.github/actions/pnpm-lockfile-check/action.yaml` default `link-workspace-packages` to `"false"` for deterministic frozen-lockfile installs.
- Update Firestore REST system test error assertions in `handwritten/firestore/dev/system-test/{firestore,pipeline}.ts` to match `google-gax@6.12.1` gRPC status code mapping.
- Regenerate `pnpm-lock.yaml` with `link-workspace-packages=false` (`0` `link:` entries and `0` `airlock-proxy` entries) against `https://registry.npmjs.org/`.
## Testing
- Verified `CI=true npx pnpm@10 install --frozen-lockfile --ignore-scripts` passes with exit code 0 and `grep -c "link:" pnpm-lock.yaml` is `0`.
- Verified Node and Bun unit tests, live GCP system tests (`handwritten/bigquery` and `handwritten/firestore` `FIRESTORE_PREFER_REST=true`), and strict repository linter checks (`GIT_DIFF_ARG=origin/main node ./bin/linter.mjs --strict`).
## Alternatives
- Leaving older major/minor dependency floors (`google-gax: ^6.0.0`, `google-auth-library: ^11.0.0`, `@google-cloud/*-api: ^0.2.0`) in `package.json` was rejected because downstream consumers and lockfile resolutions would continue pulling stale pre-fix versions.
quirogas
force-pushed
the
chore/upgrade-internal-dep-floors
branch
from
October 22, 2026 00:18
06d6043 to
a8c1b4d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade internal core library and handwritten veneer
-apidependency floors across the monorepo.Impact
Aligns internal dependency ranges with current released workspace package versions across CI and local builds.
Changes
core/and@google-cloud/*-apidependency anddevDependenciesversion floors acrosscore/,handwritten/,packages/,librarian.yaml, and rootpackage.json(includinggaxios@^8.3.1,gcp-metadata@^9.2.1,google-auth-library@^11.3.1,teeny-request@^11.1.1, and@google-cloud/bigquery-storage@^6.3.0), while keeping@google-cloud/commonpinned to8.0.1until@google-cloud/common@8.2.2is released..github/actions/pnpm-lockfile-check/action.yamldefaultlink-workspace-packagesto"false"for deterministic frozen-lockfile installs.handwritten/firestore/dev/system-test/{firestore,pipeline}.tsto matchgoogle-gax@6.12.1gRPC status code mapping.pnpm-lock.yamlwithlink-workspace-packages=false(0link:entries and0airlock-proxyentries) againsthttps://registry.npmjs.org/.Testing
CI=true npx pnpm@10 install --frozen-lockfile --ignore-scriptspasses with exit code 0 andgrep -c "link:" pnpm-lock.yamlis0.handwritten/bigqueryandhandwritten/firestoreFIRESTORE_PREFER_REST=true), and strict repository linter checks (GIT_DIFF_ARG=origin/main node ./bin/linter.mjs --strict).Alternatives
google-gax: ^6.0.0,google-auth-library: ^11.0.0,@google-cloud/*-api: ^0.2.0) inpackage.jsonwas rejected because downstream consumers and lockfile resolutions would continue pulling stale pre-fix versions.