Skip to content

Throw a catchable URIError from decodeURI and decodeURIComponent - #10

Open
puskuruk wants to merge 1 commit into
mainfrom
fix/uri-error-thrown-not-aborted
Open

puskuruk wants to merge 1 commit into
mainfrom
fix/uri-error-thrown-not-aborted

Conversation

@puskuruk

@puskuruk puskuruk commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

A malformed escape in decodeURI/decodeURIComponent aborted the process. It now throws a catchable URIError, which Nest's router relies on for /%FF. The string-literal overload is taken by const char* ahead of the bool overload so the message is not coerced.

  • 6b5ff2c Throw a catchable URIError from decodeURI and decodeURIComponent instead of aborting, and take a string literal by const char* ahead of the bool overload (gate: gained decode-uri-component-malformed-throws-uri-error, 0 moved)

Verification: npm run build passed, npm run gate -- --write exit 0, node scripts/run-runtime-tests.mjs --only decode-uri-component-malformed-throws-uri-error 1 ok, prettier clean.

Related

Independent of the other three compiler fixes (#7, #8, #9); all four go into compiler release 1.0.38, which node-compat geastack/node-compat#8 (compile hello-nest ahead of time) needs.

Rebased onto main d281cde (1.0.41) on 2026-10-20; gate byte-identical and the runtime test green there.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 604f3677-0afc-43e4-99d8-d7f817d1fc05
📥 Commits

Reviewing files that changed from the base of the PR and between d281cde and 6b5ff2c.

📒 Files selected for processing: 3
  • scripts/emitted-baseline-runtime.txt
  • src/targets/cpp/runtime/gea_runtime.h
  • test/runtime/decode-uri-component-malformed-throws-uri-error.runtime.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@puskuruk

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…ead of aborting, and take a string literal by const char* ahead of the bool overload (gate: gained decode-uri-component-malformed-throws-uri-error, 0 moved)
@puskuruk
puskuruk force-pushed the fix/uri-error-thrown-not-aborted branch from bd72d5b to 6b5ff2c Compare October 20, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant