Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 19, 2026
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 19, 2026 20:25
5d218b9 to
be6383d
Compare
puskuruk
force-pushed
the
nest/aot-hello-nest
branch
from
October 19, 2026 20:25
16bf804 to
714d794
Compare
Collaborator
Author
|
@coderabbitai review |
|
… route decorators with the checker into a generated module function
…ped shims the AOT-generated application drives
…ansform plugin in build.mjs
…inst its Node oracle over eleven requests
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 20, 2026 04:33
be6383d to
beb3f1d
Compare
puskuruk
force-pushed
the
nest/aot-hello-nest
branch
from
October 20, 2026 04:33
714d794 to
f6c7b52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apps/hello-nest(a decorated controller onNodeAdapter,@nestjs/core12.1.3) compiles with geatsc.tools/nest/aotresolves@Module,@Controller,@Injectableand the route decorators with the TypeScript checker into a generated module function;scripts/build.mjsruns it as a compiler source-transform plugin, andreflect-metadataand the three@nestjspackages map to typed shims the generated application drives.Needs the four compiler fixes (compiler release 1.0.38); the floor bump in package.json follows once that release exists.
Verification:
node scripts/test-hello-nest.mjs→HELLO_NEST_PARITY: 10 of 11 identical. The one deviation is theJSON.parseerror message wording onPOST /jsonwith a malformed body (compiler item D7).Benchmark
Same app under Node and compiled,
bench/http-matrix.py(Nest 4/4), 2026-10-19, arm64 Ubuntu 24.04 container on an 8-vCPU Colima VM (Apple M1), VM otherwise idle: 2 s warmup, 8 s samples,wrk -t4 -c64, three interleaved rounds, server on vCPUs 0-3, wrk on 4-7. Not the bench host, so sizes carry the VM's variance (the same binaries moved 25-46% between two runs an hour apart); orders held in every round.//json//jsonFour workers,
GET /: compiled Nest 2.73× Nest on Node (2.40× at one worker), 2.03× barenode:httpon Node, 0.83× compiled Hono; PSS 1/31; startup 13-15 ms against 698 ms and 1,700 ms. Binary 7,619,264 bytes (-Os -flto, stripped). Raw records and the full ten-server table are in Nest 4/4.Related
Stack: #6 (1/4) → #7 (2/4) → this PR → #9 (4/4, benchmark harness and raw records). Needs the four compiler fixes geastack/compiler#7, geastack/compiler#8, geastack/compiler#9 and geastack/compiler#10 (release 1.0.38); the compiler floor bump follows that release.