Repository navigation
Release suite: sibling paths from the exported variables, a refusal to install over a linked node_modules, and the lanes a macOS host cannot run named instead of failed - #13
Draft
puskuruk wants to merge 5 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@coderabbitai review |
|
…the three tests that compile core's own sources, with the sibling checkout as the fallback
…out, which npm ci would empty
…the lane is named as not run everywhere else
… machine is unreachable, instead of failing the lane on a host that has the sanitizers
…compile the generated C++ of a gea-companion macOS build that no lane produces
puskuruk
force-pushed
the
fix/release-suite-sibling-paths
branch
from
October 20, 2026 07:45
d3b6c72 to
9a78921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four gaps the release suite showed on a macOS host whose checkouts are not laid out as siblings, found running
npm run release:checkfor #7-#10. None changes what a lane tests; each removes a failure that was about the harness, not the release.test/gea-commonjs.mjs,test/gea-host-namespace-members.mjsandtest/native-rtc.mjsresolved core as../corebeside the compiler checkout, although the compiler lane exportsGEA_CORE_ROOT. They now read the variable first and fall back to the sibling. Verified from a worktree with no core beside it: all three pass with the variable set.scripts/release-setup.mjsrannpm ciin a worktree whosenode_moduleswas a link to another checkout's install, and npm emptied that checkout. Setup now refuses such a directory, naming the link's target.dashwin-geastackfrom macOS and failed when that machine was unreachable. When neitherGEA_PARALLEL_HOSTnor the default host answers anssh -o BatchMode=yesprobe, the fixtures build and run on this host, which has the sanitizers they need; the choice is printed. Verified:--only=parallelpasses on this Mac with the host unreachable (656 s for the native step alone; beside a gate run and a container build the stress fixture under ThreadSanitizer exceeded the runner's 300 s cap, so the lane wants the machine to itself).run-gea-companion-*.shtests compile the generated C++ of a gea-companion macOS build under apple'stargets/macos/generated/gea-companion, which no lane produces. They are named in the summary as not run, as the suite already does for host-bound tests, until a lane produces that build.Related
GEA_COMPILER_CLIandGEA_COMPILER_RUNTIMEthe same way.